Its-Haze / league-rpc

Just a better Rich Presence for League of Legends. Showcasing Live Game Stats, Summoner Icons, Rank Emblems and Champion Skins on Discord.
GNU General Public License v3.0
28 stars 6 forks source link

Suggestion: Be able to override league RPC after it's already open #55

Closed DereC4 closed 5 months ago

DereC4 commented 5 months ago

←[33mThe Native League Presence is still active. Please start this application before launching League of legends to fully disable it.←[0m

This message comes up sometimes when I launch the app and I'm not sure why because I set in flags to launch with league itself too; could there be a way to eliminate the league rpc in as many cases possible

Its-Haze commented 5 months ago

So here is the thing.

Leagues native rpc initializes during log in, automatically.

LeagueRPC tries to look for a plugin file, and remove the discord rpc from it.

The only problem is that league automatically repairs it's plugin file everytime you start the client.

So leagueRPC always has to fight the repair system and try to make sure the discord plugin stays deleted.

So it looks like your league client manages to repair the file, even after leagueRPC has ran.

Try this:

The reason for doing this in that order, is to make sure you give leagueRPC time to actually disable the native presence. Because i think you might have "automatic login" activated. Which should work still, but i want to know if it helps when u give the my app more time.

Let me know how it goes

Its-Haze commented 5 months ago

How did it go?

Its-Haze commented 5 months ago

Closing due to inactivity. and overriding the default league presence is already a feature.