search

Its-Haze / league-rpc

Just a better Rich Presence for League of Legends. Showcasing Live Game Stats, Summoner Icons, Rank Emblems and Champion Skins on Discord.
GNU General Public License v3.0
28 stars 6 forks source link

[FEATURE] Translation support #63

Closed Suburbanno closed 2 months ago

Suburbanno commented 2 months ago

Could you add support for strings translation?

Its-Haze commented 2 months ago

Not sure i understand the feature request.

What language, and what strings?

Suburbanno commented 2 months ago

Not sure i understand the feature request.

What language, and what strings?

PT-BR

Terminal strings, "League RPC is ready!", "Disconnected from the League API" etc.

Btw, the names of the skins are in portuguese but it's pulling the name of the chroma in english

Its-Haze commented 2 months ago

I understand that it would be nice to have the application in your native language. But I don't think this is a feature that I will be able to support. You are free to submit a pull request to add this feature if it's something you value.

Regarding the Chroma names. I can only find the names of the chromas in English. There doesn't seem to be any public data set which i can query for the chroma name in other languages other than en-US. Which is sad, but I can't do much about it.