search

ItsDeltin / Overwatch-Script-To-Workshop

Converts scripts to Overwatch workshops.
207 stars 26 forks source link

don't add collection vars unless used #181

Closed Protowalker closed 4 years ago

Protowalker commented 4 years ago

Solves #131

Protowalker commented 4 years ago

This should be fine, but I need to test that array builder still makes everything generate before I push it.

Protowalker commented 4 years ago

If you take advantage of arrayBuilder without explicitly using the extended collection, this fails.

Protowalker commented 4 years ago

Partially fixed; it doesn't generate the player collection if not necessary but it does still generate the arrayBuilder and, by extension, the global collection

Protowalker commented 4 years ago

Spoke with Deltin, the solution he wants will require more work than this