ItsDeltin / Overwatch-Script-To-Workshop

Converts scripts to Overwatch workshops.
209 stars 26 forks source link

2.0 Preview B Game Settings Not Compiling Correctly #221

Closed Jordan-Ireland closed 3 years ago

Jordan-Ireland commented 3 years ago

When compiling Deathmatch Game Length In Minutes, it doesn't compile correctly. It puts in a % when it should just be a number.

Example:

JSON File

"Modes": {
    "Deathmatch": {
      "Enabled Maps": [
        "Workshop Island"
      ]
      "Game Length In Minutes": 14
    }
  }

Workshop Output

Deathmatch
        {
            Game Length In Minutes: 14%
            enabled maps
            {
                Workshop Island
            }
        }

Expected Output

Deathmatch
        {
            Game Length In Minutes: 14
            enabled maps
            {
                Workshop Island
            }
        }
Protowalker commented 3 years ago

Your JSON file doesn't seem to be valid; that won't fix this issue but if you can give a valid one it'll help more with testing.

Protowalker commented 3 years ago

UPDATE: the problem was on my end; give me one sec to fix this linux bug and then I'll work on this for you.

Jordan-Ireland commented 3 years ago

UPDATE: the problem was on my end; give me one sec to fix this linux bug and then I'll work on this for you.

I could upload the entire JSON file that is working besides that one line if that would help? Also, off topic when would an update for the new overwatch update be?

Protowalker commented 3 years ago

@Jordan-Ireland 2.0 preview has support for all of the new features. If you mean "when does the finished version come out," the answer is "soon, but not super soon."

Jordan-Ireland commented 3 years ago

@Protowalker When I tried importing code it said the Create Effect function wasn't correct. Since colors are selectable variables and can be RGB color values I think it messed it up. I even tried using an old project that was working pre-update (11/17/20) and it gave me an error. Error: Expected a value after 'Sphere,' on line 117 My code: CreateEffect(AllPlayers(Team.All), Effect.Sphere, Color.Green, Vector([], -10, []), 10.2, EffectRev.VisibleToPositionAndRadius); Line 117 that the compiler output gave: Create Effect(All Players(Team(All)), Sphere, Green, Vector(Empty Array, -10, Empty Array), 10.2, Visible To Position and Radius);

You can ignore this. This was an error on my part.