search

ItsEcholot / ContainerNursery

Puts Docker Containers to sleep and wakes them back up when they're needed
MIT License
94 stars 6 forks source link

Configurable Proxy Listening Port #13

Closed everythingguy closed 2 years ago

everythingguy commented 2 years ago

Resolves #1

dapor2000 commented 2 years ago

Please someone merge this. With the default config the container is unusable with unRAID Server

ItsEcholot commented 2 years ago

@dapor2000

With the default config the container is unusable with unRAID Server

It is usable. Either a) run the container with bridge networking and change the port mapping to whatever port you want or b) change the unraid webui port.

Option a is easier and much better in general.

dapor2000 commented 2 years ago

It is usable. Either a) run the container with bridge networking and change the port mapping to whatever port you want

sorry my mind went blank

Sure its no problem

everythingguy commented 2 years ago

@ItsEcholot I am confused on what you mean by "The actual listening port isn’t changed by this PR". Are you referring to the placeholderServerListeningPort?

ItsEcholot commented 2 years ago

Ah my fault I misread the code. But the point about it not reloading the settings still stands.

everythingguy commented 2 years ago

I have implemented the live reload for the proxy port. Would it be better to use an event emitter instead of the updateProxyServer function?

ItsEcholot commented 2 years ago

I like the #14 approach better, thanks for providing an alternative.