Closed Samurai1201 closed 8 months ago
Thanks for the PR, could we change the name of the config & feature from fancyName
to displayName
? That way the meaning behind the configuration is better conveyed. Besides that, it looks good to me.
Yes that would actually be easier to understand for the user. Updated everything to display name, instead of fancy name. Should be ready to merge.
Sorry, one more change request: Could we make the setting displayName
optional and fall back to the current way of just using containerName
for the x-container-nursery-container-name
header if displayName
is not present?
That way this wouldn't be a breaking change which requires everyone to add displayName
for every container in their settings file.
No problem, didn't think about how this could affect people updating...
Added fall back to containerName and updated Readme to represent displayName as optional.
Merged, thanks! I will create a release and push it to the container registry 👍
Docker image released 🎉
The new version doesn't seem to include the patch...
I just updated to add the displayName function to my setup, but it didn't work as expected. So i checked the compiled code in the build folder of the container and it didn't contain the patch.
I'm somewhat new to docker, but in my testing I always had the use npm run build
before using docker build .
.
@Samurai1201: You are absolutely right, thanks. I got so focused on getting the multi-arch build process working (again) that I completely forgot to actually transpile the source. Should be fixed in the latest docker image.
Added a variable in the config file that is used on the placeholder instead of the container name. Users can now set a different name to be displayed on the placeholder just by setting the fancyName variable in the config file.
Resolves #44