search

ItsJonQ / g2

✨ An experimental reimagining of WordPress components
http://g2-components.com/
MIT License
105 stars 12 forks source link

Remove automatic ref forwarding in core elements #199

Closed sarayourfriend closed 3 years ago

sarayourfriend commented 3 years ago

Testing instructions

run yarn start, open Storybook and ensure nothing is broken, especially in components that use forwarded refs like TextInput. Ensure refs of core elements are able to be retrieved (for eample in TextInput where we retrieve a ref of a View which is just the div core element).

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/itsjonq/g2/8995uz3h4
✅ Preview: https://g2-git-fix-remove-automatic-ref-forwarding-core-elements.itsjonq.vercel.app

sarayourfriend commented 3 years ago

I'm not sure why Vercel failed, the build passes locally just fine 🤔 I'm not able to see anything when I follow the details link either. Maybe someone else has access that I don't? @jorgefilipecosta I've seen you contribute to parts of this project, do you have access to Vercel by any chance? Q is away for the holidays so I don't want to bug him.

jorgefilipecosta commented 3 years ago

@jorgefilipecosta I've seen you contribute to parts of this project, do you have access to Vercel by any chance?

Hi @saramarcondes, Unfortunately, I don't have access to vercel :(

gziolo commented 3 years ago

It looks like it helped 😃