ItsJonQ / g2

✨ An experimental reimagining of WordPress components
http://g2-components.com/
MIT License
105 stars 12 forks source link

SelectDropdown: zIndex issue #241

Closed ItsJonQ closed 3 years ago

ItsJonQ commented 3 years ago

After the recent SelectDropdown update, I've noticed a z-index issue.

Screen Shot 2021-01-21 at 3 42 54 PM

Previously, the menu content was Portal'ed, which allowed for the layering to work correctly. The updated SelectDropdown is no longer Portal'ed, meaning we need to be more specific with where is z-index applied.

Bonus: We should adjust the numbers in our z-index registry to match that from Gutenberg: https://github.com/WordPress/gutenberg/blob/master/packages/base-styles/_z-index.scss