search

ItsJonQ / g2

✨ An experimental reimagining of WordPress components
http://g2-components.com/
MIT License
105 stars 12 forks source link

Do not use ForwardRefRenderFuction #281

Closed sarayourfriend closed 3 years ago

sarayourfriend commented 3 years ago

This simplifies the type and removes duplication of the children type which is problematic for elements like hr and img which do NOT have children.

Eventually we'll remove children from ViewOwnProps but that's a project for another day and will require a big refactor in the already ported component's types to explicitly annotate children. We should probably do this sooner than later though (probably this should be the first thing we do once these libraries exist in Gutenberg).

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/itsjonq/g2/9ZgsmnMthRQKPK7mECGHdgHtf9gH
✅ Preview: https://g2-git-fix-do-not-use-forward-ref-render-function-itsjonq.vercel.app