ItsJustSbu / Shipping-website

0 stars 0 forks source link

File structure concerns #1

Open markuptitan opened 1 day ago

markuptitan commented 1 day ago

Hey Sbu, this project seems to be left unmantained anymore but I believe it still has not only room for minor improvements but also clarity.

  1. Documentation - Right now we have a repo filled with:
/Shipping-website
├── CSS
│   ├── checkout.css
│   ├── styles.css
│   └── trips.css
├── html
│   ├── 1636492530115.jpg
│   ├── checkout.html
│   ├── index.html
│   ├── logo.svg
│   └── trips.html
├── img
│   ├── bg.jpg
│   ├── hawaii.jpg
│   ├── jamaica.jpg
│   ├── spain.jpg
│   └── uae.png
├── js
│   ├── script.js
│   ├── store.js
│   └── update.js
└── README.md

which in many cases may seem straightforward but sometimes confusing to people when they visit your repo. Maybe add a start script or include steps on how to clone and what file to open when testing the project on their system.

  1. Unclear concepts - As the docs are a bit unclear I may have missed why the folder img exists. In your js/script.js file as well there is code related to consuming an Openweather API which may be irrelevant to a Shipping Website project.

  2. Unmatching currencies: js/update.js in the function updateCartTotal() you use Rands while in in checkout.html you used $.

ItsJustSbu commented 1 day ago

This was a project for learning how to build websites with html. css and js, I was not planning to keep it maintained But I hear you, I think just for fun, I will work on it on weekends