ItsLewizzz / DeluxeHub

:floppy_disk: All-in-one, essential and professional hub core solution.
https://www.spigotmc.org/resources/49425/
GNU General Public License v3.0
90 stars 77 forks source link

EssX loadbefore contributes to plugin load order messes #110

Open mbax opened 10 months ago

mbax commented 10 months ago

The loadbefore in plugin.yml contributes to a bunch of cyclical dependency issues. Here's one example (see my big response further down in the issue if you're not aware of what's going on there): https://github.com/EssentialsX/Essentials/issues/5608

The typical behavior on modern servers is actually to stop loading plugins entirely. Here's an example of it on Paper:

[17:15:37] [Server thread/ERROR]: [SimpleProviderStorage] Circular plugin loading detected!
[17:15:37] [Server thread/ERROR]: [SimpleProviderStorage] Circular load order:
[17:15:37] [Server thread/ERROR]: [SimpleProviderStorage]   Essentials -> DeluxeHub -> Multiverse-Core -> CrazyCrates -> ItemsAdder -> Essentials
[17:15:37] [Server thread/ERROR]: [SimpleProviderStorage] Please report this to the plugin authors of the first plugin of each loop or join the PaperMC Discord server for further help.

In this one, CrazyCrates also contributed. They have already resolved this here - https://github.com/Crazy-Crew/CrazyCrates/commit/f5cd96d2ce78cab21b8655dc34c6596b36cadee9

With it starting on the first commit, I can't find the reasoning for why you added that to the plugin.yml file. EssX always gives priority to other commands, if that's your reason (only one I can think of).

Please consider removing the loadbefore. 🙂