Closed ghost closed 2 years ago
Ok, I am willing to do that. I will add support for either BossBar, scoreboard, text and nothing. Do you have any other suggestions for ways I should display the information?
Yes, I see why this is doing this, I will fix it.
Will fix it.
4 & 5. Did you download via poggit? Since there are virions (which I will admit, I forgot to mention in README), you need to download from poggit unless you know what you are doing.
I will keep you updated.
Koth1: #name of the koth floating-text: #text of the floating text, use \n to jump between lines ft-coords: #coords of the floating text of the koth, you can use the {KING} {REWARDS} {TIME} variables rewards: #rewards given when the koth ends ....
I didnt downloaded via Poggit, i downloaded the zip via github then unarchived it to a folder and loaded it with DevTools. Now i installed via Poggit and it now works, solved.
https://poggit.pmmp.io/ci/ItsMax123/KOTH/KOTH/dev:10 here is updated version with most bugs fixed, I am not on my PC so I will add the floating text and scoreboard support this weekend, but for now I added a way for you to disable bossbar. Keep in mind this version is untested since again I am not home. Please tell if it does not work
It kicks me when i join
[15:23:44] [Server thread/CRITICAL]: Error: "Call to a member function removePlayer() on null" (EXCEPTION) in "plugins/KOTH_dev-10.phar/src/Max/koth/EventListener" at line 15
--
2 | [15:23:44] [Server thread/CRITICAL]: #0 pmsrc/src/pocketmine/plugin/MethodEventExecutor(42): Max\koth\EventListener->onJoin(object pocketmine\event\player\PlayerJoinEvent)
3 | [15:23:44] [Server thread/CRITICAL]: #1 pmsrc/src/pocketmine/plugin/RegisteredListener(80): pocketmine\plugin\MethodEventExecutor->execute(object Max\koth\EventListener, object pocketmine\event\player\PlayerJoinEvent)
4 | [15:23:44] [Server thread/CRITICAL]: #2 pmsrc/src/pocketmine/event/Event(88): pocketmine\plugin\RegisteredListener->callEvent(object pocketmine\event\player\PlayerJoinEvent)
5 | [15:23:44] [Server thread/CRITICAL]: #3 pmsrc/src/pocketmine/Player(1094): pocketmine\event\Event->call()
6 | [15:23:44] [Server thread/CRITICAL]: #4 pmsrc/src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(310): pocketmine\Player->doFirstSpawn()
7 | [15:23:44] [Server thread/CRITICAL]: #5 pmsrc/src/pocketmine/network/mcpe/protocol/SetLocalPlayerAsInitializedPacket(45): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleSetLocalPlayerAsInitialized(object pocketmine\network\mcpe\protocol\SetLocalPlayerAsInitializedPacket)
8 | [15:23:44] [Server thread/CRITICAL]: #6 pmsrc/src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(109): pocketmine\network\mcpe\protocol\SetLocalPlayerAsInitializedPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
9 | [15:23:44] [Server thread/CRITICAL]: #7 pmsrc/src/pocketmine/network/mcpe/protocol/BatchPacket(130): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\SetLocalPlayerAsInitializedPacket)
10 | [15:23:44] [Server thread/CRITICAL]: #8 pmsrc/src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(109): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
11 | [15:23:44] [Server thread/CRITICAL]: #9 pmsrc/src/pocketmine/Player(3323): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
12 | [15:23:44] [Server thread/CRITICAL]: #10 pmsrc/src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
13 | [15:23:44] [Server thread/CRITICAL]: #11 pmsrc/vendor/pocketmine/raklib/src/server/ServerHandler(95): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[19] **.**.**.** 62605, object raklib\protocol\EncapsulatedPacket, integer 0)
14 | [15:23:44] [Server thread/CRITICAL]: #12 pmsrc/src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket()
15 | [15:23:44] [Server thread/CRITICAL]: #13 pmsrc/src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process()
16 | [15:23:44] [Server thread/CRITICAL]: #14 pmsrc/vendor/pocketmine/snooze/src/SleeperHandler(113): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
17 | [15:23:44] [Server thread/CRITICAL]: #15 pmsrc/vendor/pocketmine/snooze/src/SleeperHandler(75): pocketmine\snooze\SleeperHandler->processNotifications()
18 | [15:23:44] [Server thread/CRITICAL]: #16 pmsrc/src/pocketmine/Server(2155): pocketmine\snooze\SleeperHandler->sleepUntil(double 1633620224.2302)
19 | [15:23:44] [Server thread/CRITICAL]: #17 pmsrc/src/pocketmine/Server(1992): pocketmine\Server->tickProcessor()
20 | [15:23:44] [Server thread/CRITICAL]: #18 pmsrc/src/pocketmine/Server(1586): pocketmine\Server->start()
21 | [15:23:44] [Server thread/CRITICAL]: #19 pmsrc/src/pocketmine/PocketMine(314): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[16] /home/container/, string[24] /home/container/plugins/)
22 | [15:23:44] [Server thread/CRITICAL]: #20 pmsrc/src/pocketmine/PocketMine(344): pocketmine\server()
23 | [15:23:44] [Server thread/CRITICAL]: #21 pmsrc(11): require(string[71] phar:///home/container/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
24 | [15:23:44] [Server thread/INFO]: [StaffChat] [STAFF] OutMencore disconnected
25 | [15:23:44] [Server thread/INFO]: OutMencore[/**.**.**.**:62605] logged out due to Internal server error
26 | [15:23:44] [RakLibServer thread/NOTICE]: Blocked **.**.**.** for 5 seconds
Yeah, that makes sense, sadly i wont have time to fix it until Friday afternoon so i recommend waiting
Error is fixed & Ive added scoreHud support (But that doesnt really matter since I dont think you have ScoreHud plugin) and Hotbar popup support (which is what you should enable in my opinion). Remember that you need to delete the files in plugin_data to receive the updated config files (You can copy everything in your current config file and then re-use the ones that are still there in the config file if you want.)
I´ve tested it and yes all errors are solved, nice job and nice plugin!
The unique issue i have is that the actionbar is showing with a blank space, i think that blank space can be replaced with the "KOTH" word. But its possible due to my resource pack, im not sure, you can test it and if the blank space isnt there for you i think its my fault, again nice job!
Yes i get this space too, I do not know why it is there but I do not think there is anything I can do about it sadly. I will look into it with The pocketmine people :)
Tested & Fixed
Just added an untested fix
Now actionbar does not display
Did you enable it in config? There should be a hotbar
setting in config, if there is not then you can either add it manually or delete config and restart your server and it will appear. Then just put hotbar: on
nevermind it was my "the hive" texture pack which doesn´t support tips, only popups
1) Suggestion: The bossbar is cool but some people have other things upside the screen like other bossbars or the scoreboard in my case, i suggest adding an option to disable the bossbar
2) Bug in config.yml: Comments disappear
3) /koth setpos1 and /koth setpos2 are not in the help page, this is a little mistake
4) Bug: Doing /koth start and /koth stop via console will crash the server
5) Bug when KOTH starts (at least with a command) This shows in the console and there is no message sended by the webhook