ItsRoy69 / DocTalk

DocTalk - Doctor just a click away
https://doc-talk69.vercel.app/
MIT License
42 stars 53 forks source link

doctor post & fetched api or doctor routes correctness #80

Closed mu-irfan closed 2 years ago

mu-irfan commented 2 years ago

issue : 1

Frontend doctor registration routes issue solve 📐

issue : 2

Backend doctor fetched api 📐

Guidelines 🔐

I accept the fact that i have followed the guidelines and have not copied the codes from around the internet

Issue to be closed 🛅

Screenshots 📷

Here are the pictures of changes that i have made 🔽

Code Screenshot code

Api output screencapture-localhost-5000-all-doctors-2022-08-16-10_26_31


vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
doc-talk ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 5:47PM (UTC)
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 1c6954dceafa240625cb621f5db840011f7cd3ac | server/config.env | [View secret](https://github.com/ItsRoy69/DocTalk/commit/1c6954dceafa240625cb621f5db840011f7cd3ac#diff-a85cb4561b788b8445f0e0ea7f9b4a54L1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | bfe6f7db6bdc9c04a1eb9783e65308a49545f113 | server/config.env | [View secret](https://github.com/ItsRoy69/DocTalk/commit/bfe6f7db6bdc9c04a1eb9783e65308a49545f113#diff-a85cb4561b788b8445f0e0ea7f9b4a54R1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mongo_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!