search

ItsSim / fsolauncher

Official FreeSO Launcher made with Electron
https://beta.freeso.org
Mozilla Public License 2.0
14 stars 9 forks source link

[Windows, Mac] Simitone menu item not aligned #29

Closed ItsSim closed 2 years ago

ItsSim commented 2 years ago

Describe the bug The Simitone menu item (icon and text) is not aligned with the rest of menu items.

Also using this issue to try out the new issue template.

To Reproduce Steps to reproduce the behavior:

  1. Open the launcher.
  2. See the bottom of the sidebar menu, where the Simitone menu item is.

Expected behavior The Simitone icon and text should be aligned with the rest of menu items.

Screenshots image image

Desktop (please complete the following information):

Additional context The Simitone menu item is the only item that uses an SVG element to render the icon, which is most likely why the alignment isn’t correct. Probably need to modify CSS to accommodate it.

tomgrice commented 2 years ago

All sorted I think. Tried to make it somewhat generic in case another SVG icon is added in the future, but either the CSS or the SVG code (to standardize the icon size) will probably need tweaking slightly if this happens.

31

ItsSim commented 2 years ago

Closed with #31, thanks.

I think making sure any future SVG elements are the same size will be sufficient.