Closed ItsSim closed 2 years ago
The icons:
PNG: https://imgur.com/a/dJ7hEes SVG: https://svgshare.com/i/eRk.svg (success) https://svgshare.com/i/eQS.svg (error)
Would probably use the SVG ones.
Solved with 24e49fdb15ef3dde7c509769eb932eb3d3b992db
New IPC calls: showErrorModal
, showSuccessModal
, showErrorModalNoFocus
, showSuccessModalNoFocus
Is your feature request related to a problem? Please describe. Currently, modals don’t graphically show that they are a success modal or an error modal. They all have the same appearance. Sometimes, depending on the text in the modal, it might not be as obvious to the user if something went wrong or not.
Describe the solution you'd like Modals should have 3 types: "success", "error", and "normal" or "generic".
The current modal should accept a new parameter in its invocation, declaring it as one of these types. Then it should display the modal to the user with the necessary details to indicate its type.
Here are a few example designs made in Figma:
Example normal/generic modal (no change needed):
Example success modal:
Example error modal:
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context
type
parameter. Every current modal invocation also has to be updated to pass in this new parameter.type
parameter and modify the modal’s appearance with the extra details (the checkmark or X).