ItsSim / fsolauncher

Official FreeSO Launcher made with Electron
https://beta.freeso.org
Mozilla Public License 2.0
14 stars 9 forks source link

[Windows, Mac] Modal overlay is removed before all modal popups are closed #39

Closed ItsSim closed 1 year ago

ItsSim commented 2 years ago

Describe the bug When multiple modal popups are displayed at the same time, and one of them is closed by the user, the overlay is removed.

Launcher Version The version where you've encountered the bug, and other versions that may be affected (if known). Every version.

To Reproduce Steps to reproduce the behavior: (Windows only)

  1. Open launcher
  2. Click on an item in the installer screen so that a modal pops up
  3. Right-click the play button so that the volcanic modal pops up too
  4. Close the volcanic modal
  5. See how the overlay is removed, even though there's still one more modal that hasn't been closed yet.

Expected behavior The overlay should only be removed once every modal popup is closed.

Screenshots If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

Additional context This fix is client-side only (fsolauncher.pug/client.js) Since only one overlay is created for all subsequent modals that display at the same time, when one is closed the single overlay is removed. It should check if there's still any other open modals before removing the overlay.

ItsSim commented 1 year ago

Fixed in https://github.com/ItsSim/fsolauncher/commit/d591d30985bde3e393664bd79fa01e69cbd02ea2