ItsSim / fsolauncher

Official FreeSO Launcher made with Electron
https://beta.freeso.org
Mozilla Public License 2.0
14 stars 9 forks source link

[Mac] Language switching does not work #7

Closed ItsSim closed 4 years ago

ItsSim commented 4 years ago

If you try to switch the game language from the launcher on OS X, an error will pop up. This has to do with how the language switching works: it copies the appropriate translations from the /export/ folder - which is included in the packaged .app file - to the FreeSO installation folder. Due to some strange permissions issue, the launcher is unable to find these files and copy them.

I have not had time to sort this one out and decided to publish the Mac version with this feature broken, as it is not important because translations are a bit wonky anyways (even though the translations in the launcher only include .str.piff and .cst, they are outdated/miss many strings).

ItsSim commented 4 years ago

Fixed in 791c29f3f63ea144ae64f2a2e4f2df370a03cdd0

fs has strange problems when working under Electron in order to ensure asar compatibility. Disabling asar compatibility (which makes Electron use original-fs) while copying the languages files fixed every issue: https://github.com/ItsSim/fsolauncher/commit/791c29f3f63ea144ae64f2a2e4f2df370a03cdd0#diff-438e1ca10ba9b1209b1e0fef72367725R828

This also fixes strange permission errors on Windows when updating FreeSO after having changed the language via the launcher: 38c1dd754082ac1501b558d8bbd734be04cfe41b