ItsSim / fsolauncher

Official FreeSO Launcher made with Electron
https://beta.freeso.org
Mozilla Public License 2.0
18 stars 9 forks source link

Improved Linux SDL Installer #85

Closed dark-steveneq closed 5 months ago

dark-steveneq commented 5 months ago

This PR removes unneeded libsdl2-dev dependency for Debian-based systems along with combining aptInstall() and pacmanInstall() functions into linuxInstall() along with symlinking libSDL2.so to FreeSO's folder on Arm devices since vendored SDL2 from MacExtras is an x86_64 library.

Edit: I just realized you can probably point FreeSO to use system libraries by editing MonoGame.Framework.dll.config. I'll first check if this fix work and then I'll try the MonoGame.Framework.dll.config way. Edit 2: The SDL2 and OpenAL installers can actually be "removed" for the Linux version since these packages can be set as dependencies which are automatically installed when installing the package.

ItsSim commented 5 months ago

Thanks for the PR. Are you able to revert the package-lock.json changes? They seem to be causing issues with npm ci https://github.com/ItsSim/fsolauncher/actions/runs/9000757521/job/24753354643?pr=85

dark-steveneq commented 5 months ago

Sure! I'll do it tomorrow since I'm about to go to sleep.

-------- Original Message -------- On May 9, 2024, 12:33 AM, Sim wrote:

Thanks for the PR. Are you able to revert the package-lock.json changes? They seem to be causing issues with npm ci https://github.com/ItsSim/fsolauncher/actions/runs/9000757521/job/24753354643?pr=85

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

ItsSim commented 5 months ago

There's a few issues with the formatting: https://github.com/ItsSim/fsolauncher/actions/runs/9014343500/job/24767909469?pr=85

dark-steveneq commented 5 months ago

I know, I'm working on it

dark-steveneq commented 5 months ago

Alright, everything seems to work now.

God this PR is a nightmare