search

ItsSpyce / dailies-tracker

72 stars 23 forks source link

Add German localization #1

Closed justjustie closed 3 months ago

justjustie commented 3 months ago

Added German translations, tried to keep it as close as possible to the German game localization.

I did not add a language switcher however, so currently you have to swap the hard coded i18n context and rebuild.

ItsSpyce commented 3 months ago

Thanks for the PR! I went ahead and moved things around for the i18n, it now lives in packages/i18n. Go ahead and add your file there then update the index.d.ts to match enUS and I'll merge it in!

justjustie commented 3 months ago

Moved it around, after merging your changes I cant get it to run properly anymore though... Did not change anything else, build goes through, but when I start it its just a blank page

ItsSpyce commented 3 months ago

you may have to run npm install from the root directory? I'm not quite sure what could be going on their, but if you run npm run dev from root, it'll open the dev tools automatically. Another option is using F12 to open them and see if something is throwing an error before mount

justjustie commented 3 months ago

Very strange, it just works when I run it in dev mode... I have the same problem when I check out your branch. I'm probably overlooking something really stupid

ItsSpyce commented 3 months ago

Weird, I can run it without dev mode and with. What OS are you running it on? What version of Go do you have?

justjustie commented 3 months ago

I am running go 1.22.2 on Windows 11

ItsSpyce commented 3 months ago

Either way, I'll merge this in and we can figure out why non-dev mode won't work for you! Thanks again :)

ItsSpyce commented 3 months ago

I am running go 1.22.2 on Windows 11

I'm also on Win 11 but on Go 1.21.6, maybe that's it...

justjustie commented 3 months ago

Alright, glad to help ^^ I'll just create an issue for the other problem then