Closed Honeyxilia closed 6 months ago
Thank you! I'll be taking a look shortly and merge it in once it looks good. I mentioned it in another PR but there will be a small tweak to realm names from the standpoint of i18n. That being said, it won't block this PR from being merged in. I appreciate it 🩵
As new strings have been added to the translation file, I've translated them !!
Translation note : in the french version, I've translated the Job-like realm names (Gardener, Cook) to their equivalant domain of expertive (Gardening, Cooking) - originally, i wanted to translate it by gender neutral versions of the noun with inclusive writing, but a friend of mine (@LambdAurora) positionned that it would be better to put domain-like names as to make it easier to read, and to not have to gender it at all!
Note : in the build i was working on, there was an issue in the file
packages/ui/src/images/index.js
where the exported fileAREXP.png
didnt have the correct title (ARExp.png
) - idk if you've fixed it in your current work version but i wanted to share c: