search

ItsSpyce / dailies-tracker

72 stars 23 forks source link

One of the languages doesn't work (I think it's the tagalog one??) #23

Open hllwrld7 opened 3 months ago

hllwrld7 commented 3 months ago

Describe the bug The first thing I tried to do is to test translations, I saw one of the items on the list was empty and I clicked it lol, and then the UI disappears.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on the language select dropdown menu
  3. Click on the blank item
  4. UI disappears

Expected behavior I expected to see the name of the language in all of the items in the dropdown menu.

Screenshots image

Desktop (please complete the following information):

Additional context I checked the translation files because I had the same issue of UI disappearing when I made a typo in my Russian translation file, and I think it's the tagalog translation (file packages\i18n\tg_PH.js), the const name is tgPH, but I think it should be tg_PH??? I didn't test the fix though, but I'm pretty sure this is the problem.

ItsSpyce commented 3 months ago

Thanks, I'll take a look!

ItsSpyce commented 3 months ago

After looking into this, it's an issue with the tagalog language. Because languageName is missing from the translation files, it throws a fit and basically nukes itself. Thankfully the change doesn't persist through restart. The fix is in develop but not released yet.