ItsThosea / BadOptimizations

A collection of mostly micro optimizations that add up to something bigger!
MIT License
43 stars 2 forks source link

Flickery Sky [On 2.0.0] #30

Closed R00tB33rMan closed 8 months ago

R00tB33rMan commented 8 months ago

When you enter and exit custom biomes with different sky colors, it's more prevalent that when entering and exiting these boundaries, that the sky flickers. Here's a video exemplifying this oddity:

https://github.com/ItsThosea/BadOptimizations/assets/36140389/25065d0b-f24e-4290-b34d-aeb3ba69bd50

ItsThosea commented 8 months ago

The video isn't loading.

R00tB33rMan commented 8 months ago

The video isn't loading.

Likely not compatible with your device. Only seems to load on desktop. I'll get another post sorted, below: https://streamable.com/qnrhgz

ItsThosea commented 8 months ago

Yeah, I loaded it on a computer and it worked. I see the issue, should be a pretty easy fix for when I get home.

ItsThosea commented 8 months ago

Does this 1.20.4 build fix it? mod.zip

roshavagarga commented 8 months ago

Tested the above .jar - less flickery, but there is still a change in sky colors, but not as bad as it was in 2.0.0.

Edit: Happened during storms, but I think it was fine otherwise, needs more testing.

ItsThosea commented 8 months ago

Happened during storms, but I think it was fine otherwise, needs more testing.

fixed, try this

ItsThosea commented 8 months ago

released

roshavagarga commented 8 months ago

Tested, still bugging, not as bad as before, just suddenly switches from what you can see below when moving, possibly still a biomes issue? I sadly cannot make a video, but if getting logs is an option, you can run me through that.

Photo 02 Photo 01

ItsThosea commented 8 months ago

May I have your world file?

roshavagarga commented 8 months ago

Above screenshots are from a multiplayer server.

ItsThosea commented 8 months ago

just suddenly switches from what you can see below when moving, possibly still a biomes issue

I think you're just on the biome border where both biomes have different sky colors, which means it works as intended. Try w/o BO and see if the results are the same.