ItsThosea / BadOptimizations

Optimization mod that focuses on things other than rendering
MIT License
36 stars 2 forks source link

incompatibility with SideKick mod #51

Closed peow closed 5 months ago

peow commented 5 months ago

This mod (https://modrinth.com/plugin/sidekick) adds a new Creative Menu, where you can activate special functions, such as "Full Bright" image

However, when trying to activate this function together with BadOptimizations, some problems occur

1) BadOptimizations considers "Full Bright" as a normal change in the light of the world, so it is only updated after a few ticks, according to the option "lightmap_time_change_needed_for_update:"

2) when the doDaylightCycle gamerule is disabled, Full Bright does not work (since the time isnt changing), you need to manually change the time of day (like /time set 13500), so BadOptimizations understands lightmap should change


install both mods enter in a creative world type /time set night type /gamerule doDaylightCycle false open the new Creative Menu and enable "Full Bright" option wait to see if something changes type /time set 13500 to advance the night


the "Full Bright" function stands out over the BadOptimizations settings

peow commented 5 months ago

forgot to say: im using Fabric 1.20.1 BadOptimizations 2.1.0 Sidekick v2.0.5

if is possible to fix this pls publish an update to 1.20.1, tx

ItsThosea commented 5 months ago

Probably not fixable due to their implementation of it. However is there any reason you can't use something else like Boosted Brightness? It's still toggleable.

peow commented 5 months ago

I understand the Sidekick is more practical as it is an on/off button

ItsThosea commented 5 months ago

Boosted Brightness has customizable hotkeys to increase/decrease its brightness.

peow commented 5 months ago

i see

ItsThosea commented 5 months ago

So uhm...is your issue fixed?

peow commented 5 months ago

you can close the Issue, as I know what caused the problem, its easier to get around it