search

ItsThosea / BadOptimizations

A collection of mostly micro optimizations that add up to something bigger!
MIT License
43 stars 2 forks source link

Crash with xenon on 2.1.2 #59

Closed mxnmnm closed 4 months ago

mxnmnm commented 4 months ago

I tried entering my world but I got this crash. It only happens on 2.1.2 and moving back to 2.1.1 fixes it. https://gist.github.com/mxnmnm/de81efc6c2bb6a69ad10c217c92aa8db

ItsThosea commented 4 months ago

Today I learned that @Unique is a lie and complete garbage and should never be used. I'll fix this when I'm home. Edit: I just pinged somebody random

ItsThosea commented 4 months ago

Fixed. It'll take a bit to appear on curseforge, but you can download it off modrinth here.

Seems like Modrinth is being DDoS'ed or something cause everything write-related is super slow. Took like 20 minutes for the jars to appear. I also can't modify the featured list right now, so you'll have to view the full list to find it.

SrRapero720 commented 4 months ago

honestly is a little bit my fault to for not rename the method to something mixin-friendly

Today I learned that https://github.com/unique is a lie and complete garbage and should never be used.

Unique works on methods and fields defined on the mixin context, methods from implemented interfaces are not renamed, otherwise will cause a hell in runtime and for APIs if the method have to be renamed everywhere