ItsThosea / BadOptimizations

Optimization mod that focuses on things other than rendering
MIT License
36 stars 2 forks source link

Config Option 'enable_entity_renderer_caching: true' will cause incompatibility/crash with BedrockSkinUtility mod. #69

Open MrBsng opened 2 weeks ago

MrBsng commented 2 weeks ago

Disabling it will allow BedrockSkinUtility to load. This crash happens right before the main menu of the game loads. I've taken all my client side mods out except fabric api to test with these two mods. I suggest adding this mod to the config file for incompatibility for enable_entity_renderer_caching if there is not a fix.

---- Minecraft Crash Report ---- Description: Initializing game

java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_898 failed at net.minecraft.class_310.(class_310.java:582) at net.minecraft.client.main.Main.main(Main.java:239) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_898 failed at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ... 5 more Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ... 9 more Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method getRenderer(Lnet/minecraft/class_1297;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V in BedrockSkinUtility.mixins.json:EntityRendererDispatcherMixin from mod bedrockskinutility failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap BedrockSkinUtility-refmap.json at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327) at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:422) at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ... 12 more

ItsThosea commented 2 weeks ago

Meh, I haven't been modding for a while to work on my game. But yeah, this'll be here next update. When is that next update? Probably when 1.21.2 releases.

MrBsng commented 2 weeks ago

Meh, I haven't been modding for a while to work on my game. But yeah, this'll be here next update. When is that next update? Probably when 1.21.2 releases.

The mod works when I set the option to false, its not a big deal other than to add a comment for anyone in the future that may stumble upon this. No rush.

ItsThosea commented 2 weeks ago

This is the 3rd mod to break with the entity renderer optimizations.

MrBsng commented 2 weeks ago

This is the 3rd mod to break with the entity renderer optimizations.

Darn. How about a section in the readme that list the mods that break with the entity renderer optimizations. I'm also awaiting response from the other issue in https://github.com/Camotoy/BedrockSkinUtility/issues/21

MrBsng commented 2 weeks ago

Also good luck on the new game.

ItsThosea commented 2 weeks ago

How about a section in the readme that list the mods that break with the entity renderer optimizations.

Alternatively-

If your mod doesn't work with BO, it's probably because of the evil, the unforgiving, the wicked and vile entity renderer optimizations! Disable it in your config file, and see if it still breaks…

MrBsng commented 1 week ago

How about a section in the readme that list the mods that break with the entity renderer optimizations.

Alternatively-

If your mod doesn't work with BO, it's probably because of the evil, the unforgiving, the wicked and vile entity renderer optimizations! Disable it in your config file, and see if it still breaks…

Yes but I've worded it better here if you want to use this:

Certain mods can break with BO, it's probably because of the evil, the unforgiving, the wicked and vile entity renderer optimizations! Set enable_entity_renderer_caching: false in the BO config file, and see if it still breaks…