search

ItsWendell / google-assistant-desktop-client

A Cross-Platform client for Google Assistant, written in NodeJS / Electron.
136 stars 21 forks source link

Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style #6

Closed piccinnigius closed 6 years ago

piccinnigius commented 6 years ago

Hi, i searched to fix that issue editing '.editorconfig' and /test/.eslintrc files but doesn't work. I'm working under windows 10, any help? Thank you

ItsWendell commented 6 years ago

@piccinnigius I see that you solved this yourself? Care to share what happened and how you solved this?

piccinnigius commented 6 years ago

@WMisiedjan Yeah, i solved with command:

npm run lint -- --fix

when i try to build or run dev i get this error:

Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

then: npm run lint -- --fix fixed this errors

ItsWendell commented 6 years ago

Nice I'll keep track too see if this issue happens more often, I'm on Windows 10 too, I don't have the issue but I know it might be something to do with git converting the files

piccinnigius commented 6 years ago

@WMisiedjan i've again issued this error and finally found the origin and fixed. This issue happen when you clone the git and can be fixed by downloading the .zip file from Github instead of cloning or on cloned repo you can:

  1. open with Notepad++ .src\main\index.js

  2. go to edit>EOL Conversion > Unix (LF) > Save

PS. If in the build log see other similars errors on other files do the same thing