search

ItsWendell / google-assistant-desktop-client

A Cross-Platform client for Google Assistant, written in NodeJS / Electron.
136 stars 21 forks source link

Linux transparency, (Electron Issue reports multiple OSs) #8

Open tankerkiller125 opened 6 years ago

tankerkiller125 commented 6 years ago

Apparently, there is a known issue with hardware accelerated Chrome (Electron) where transparency shows up as white. Apparently, there is a fix as noted in electron/electron#2170

tankerkiller125 commented 6 years ago

I've actually solved this issue by putting app.disableHardwareAcceleration(); just above the app.ready() code in the index.js file.

ItsWendell commented 6 years ago

@tankerkiller125 Hi! I've read this discussion and tried to implement this fix (it should be already on the development branch).

I switched last week from Windows 10 to Ubuntu 18.06 as my daily driver. I'm on Linux too now and had this issue, I applied a fix for transparency by delaying the creation of the BrowserWindow which works fine on Ubuntu 18.04.

What distro are you on?

tankerkiller125 commented 6 years ago

Elementary OS (based on Ubuntu 16.04) I actually relized the white went away without this but it it still wasn't transparent and instead was solid black.

ItsWendell commented 6 years ago

@tankerkiller125 can you share your experience with us on Linux? What are you intending to do with the project? :)

tankerkiller125 commented 6 years ago

@ItsWendell Right now I'm just experimenting with it, but in the future, I could see this project being something that I can actually use on a day to day basis.

cromefire commented 5 years ago

Ubuntu 18.04, app.disableHardwareAcceleration(); works, the delay not

cromefire commented 5 years ago

But that only seems to work for the assistant window while it is not yet loaded

ItsWendell commented 5 years ago

For some reason locally here for me I don't have any problems at all since upgrading, @cromefire what are you using exactly?

cromefire commented 5 years ago

uname: Linux tpu 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux OS: Ubuntu 18.04.1 LTS NVIDIA proprietary driver v390.77 on GTX 960

Also the response window now also works with that change

ItsWendell commented 5 years ago

Just tested on Fedora 29 (Gnome) and MacOS Sierra (10.12.6) both work fine, also updated some packages and electron to 4.0.3, let me know how this works now!

cromefire commented 5 years ago

It's still not working without disabling the acceleration, for me it seems to be a problem with the proprietary NVIDIA graphics drivers for Linux that might be the issue, so it should simply disable hw accel on linux, there's nothing demanding in this app which needs hw accel