Open nperez0111 opened 5 days ago
@ItzCrazyKns This looks like a professional enhancement to this lovely project. +1 for this
Hey @nperez0111, thanks for the PR! All of the changes looks good but I cannot merge the CI pipeline for the docker image building as if the config.toml
file doesn't gets configured correctly, the page won't load and it would throw an error, some of the fields are still not present in the config menu to be configured from the frontend so that might cause an issue, we can implement the CI part later when these things are implemented.
Hi, really like the project. I wanted to have docker images that were already pre-built to self-host. So, I got the project building in GitHub Container Registry & built automatically in CI.
Definitely some optimizations could be made to the Docker images to get this to work better though like:
One thing that I had to do though, we not modify the config file (since that is better handled by a volume) at build time to include the build time arg. So what I did was make env vars be a fallback for values that are actually specified in the config (so updating the config should always override an env var declarations)
You can see the docker images (and pull them if you like!) here: