ItzNotABug / ghosler

Send newsletter emails to your Ghost CMS subscribers & members, using your own email credentials!
Apache License 2.0
40 stars 5 forks source link

Cannot read properties of null #39

Closed jvmonjo closed 3 months ago

jvmonjo commented 3 months ago

Hi. I have ghosler dockerized but I haven't managed to get it working. This is the error log it keeps showing when I publish a new post.

''' [ERROR] => Newsletter: TypeError: Cannot read properties of null (reading 'replace') at Object.decode (/ghosler/node_modules/he/he.js:232:15) at file:///ghosler/utils/newsletter.js:218:58 at Array.forEach () '''

ItzNotABug commented 3 months ago

Hey 👋, a bug was recently fixed that had a similar signature. Whats the installed ghosler version on your server?

jvmonjo commented 3 months ago

Sorry. I couldn't find a similar issue the other day and today I have opened the issue maybe just too fast. I'm using the docker hub version hdsplus/ghosler:latest which I've just pulled and it seems it's using Ghosler 0.92

jvmonjo commented 3 months ago

I've just figured out I needed to remove the volume to rebuild the latest ghostlier version. I guess we need a better docker architecture so we don't have to remove ghosler data every time,e we need to update.

Now I have 0.93 and a different error:

[ERROR] => Newsletter: Error: C047036F917F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../ssl/record/ssl3_record.c:354

ItzNotABug commented 3 months ago

Sorry. I couldn't find a similar issue the other day and today I have opened the issue maybe just too fast. I'm using the docker hub version hdsplus/ghosler:latest which I've just pulled and it seems it's using Ghosler 0.92

Understood. I do see that it was updated like 4 days ago, same day I released a fix for this.

You could either directly contact @viriatusX or see what link in your configuration is null at the moment. Does your Ghost site also contain an image logo? I mean that's something that could be null. Not sure any other URL would be null.

ItzNotABug commented 3 months ago

I've just figured out I needed to remove the volume to rebuild the latest ghostlier version. I guess we need a better docker architecture so we don't have to remove ghosler data every time,e we need to update.

Now I have 0.93 and a different error:

[ERROR] => Newsletter: Error: C047036F917F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../ssl/record/ssl3_record.c:354

Seems something with ssl maybe.

If the docker version is bumped to 0.93 in the meantime then that should be a stable build without any further issue while I investigate things for dockerizing Ghosler.

Thanks.

ItzNotABug commented 3 months ago

Hey @jvmonjo, Ghosler now has official Docker support out of the box and has the latest source including the fix you are looking for.

Please refer the README on how to install Ghosler on Docker.

jvmonjo commented 3 months ago

Awesome implementation of the docker version. Now with persistent volumes for configuration, logs and analytics! Congrats!

Unfortunately I'm still getting ssl error, but it may be some configuration on my end, maybe with nginx proxy. I'll keep investigating.


Newsletter: Error: 683BFA09257F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354
ItzNotABug commented 3 months ago

Hey @jvmonjo, a quick google search popped up this - https://stackoverflow.com/questions/50840101/curl-35-error1408f10bssl-routinesssl3-get-recordwrong-version-number

Possibly this could be helpful.

jvmonjo commented 3 months ago

Thanks. I've already fixed it!

In case anyone else struggles with this, I was just using the wrong smtp port on my configuration.