Iv4nS / mraid-web-tester

Automatically exported from code.google.com/p/mraid-web-tester
0 stars 0 forks source link

Display of IAB ad, Expandable #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use the aroniabtestad.zip to get the ad unit
2. Prepare and Flight the ad using the tool
3. Ad does not display

What is the expected output? What do you see instead?
* Ad should display and should respond to and generate expand events.

Original issue reported on code.google.com by nathan.c...@crispmedia.com on 7 Oct 2013 at 8:03

GoogleCodeExporter commented 9 years ago

Original comment by nathan.c...@crispmedia.com on 7 Oct 2013 at 8:04

Attachments:

GoogleCodeExporter commented 9 years ago
I'll handle this one.

Original comment by samuel....@gmail.com on 18 Oct 2013 at 10:54

GoogleCodeExporter commented 9 years ago

Original comment by samuel....@gmail.com on 21 Oct 2013 at 9:13

GoogleCodeExporter commented 9 years ago
Hey guys,

I've committed the code to get this ad unit working - I have one question that 
I can't seem to find the answer for in the specs...

On orientation change, if the ad in in default state (inline placement), does 
the ad container change width, meaning that the width reported by the 
getCurrentPosition API is updated?

Original comment by samuel....@gmail.com on 10 Nov 2013 at 3:56

GoogleCodeExporter commented 9 years ago
Sam,

Thanks for the update. For getCurrentPosition, if the ad is in default
state, then getDefaultPosition and getCurrentPosition should return the
same values. The x,y values will change with orientation. And I would
expect height to stay the same.

As for width, you are right there is nothing in the standard. In practice,
I have seen that the width does change so that the banner space is always
the width of the screen. (I've also seen it stay static -- container is
always 320 wide for example -- but that is less common.)

So I think we have the opportunity to do either. My vote is to have the
width be the width of the screen if that's what the initial setup is, and
to have it be static if they are not equal. That way I can test phone
banner ads (flex), but also tablet medium rectangle expandables (static)
too.

Original comment by nathan.c...@crispmedia.com on 11 Nov 2013 at 2:41

GoogleCodeExporter commented 9 years ago
Thanks for the update, Sam. We've reviewed with the IAB compliance ads, so 
changing this over to Done.
-Nathan

Original comment by nathan.c...@crispmedia.com on 28 Apr 2014 at 6:16