Permission to submit to Windower4

[Iminiillusions]

Hey there, I've made some fixes to Skillchains as of late, and would like you're permission to submit it to the Windower team for Official Release. Would you be ok with that?

[Ivaar]

There were a few things I wanted to address before submitting it for review, but I haven't had enough time lately. The biggest issue I can remember had to do with the timer. Some areas of the code I would like cleaned up, such as the check if the weapon skill can be continued, this can cause issues iirc. What exactly did you fix? Post me a link so I can take a peek.

[Iminiillusions]

I'm not the first person to make changes to it, however I did fix some things I noticed that were a bit janky after the first person modified it. All changes are noted in the lua itself. Here is the link: https://github.com/Iminiillusions/Windower4-Addons/tree/master/Skillchains

[Ivaar]

Have you not tried the latest version? I've made heavy changes since my return to ffxi last fall.

[Ivaar]

I incorporated all of sammehs logic and applied a fix submitted by sebyg666

[Iminiillusions]

tbh I haven't seen you're GitHub, when I found Skillchains, I found it on Sammeh's GitHub, so I never saw you're particular work/version

[Ivaar]

It was somewhat optimized now uses 1mb tops vs 30mb memory before, It can still use some work

[Iminiillusions]

i'll look at it now :)

[Ivaar]

What do you think of the changes? I prefer setting bg.visible to false when using color setting as its easier on the eyes (in some areas). I just checked my local copy, seems I changed >> to → and forgot to commit it. I've updated the repo. I was going to post some screenshots to show off some of the different ways you could customize it. Also, I wanted to add a setting for newline after each property or element so the user could have them stack vertically below the timer and turn all the other info off if desired.

[Iminiillusions]

It looks very well done, I've always enjoyed it, as its very useful in TP burn situations, closing random skillchains. There's one thing i wanted to add but was having issues with, and thats custom transparency. I find that it takes up a bit to much screen real estate and transparency would help a lot with that.

[Ivaar]

Open the settings.xml file and set bg visible to false, I also left some code for that commented out, but you would have to delete settings.xml before reloading.

[Ivaar]

[Iminiillusions]

Ahh, got ya, i tend not to mess around too much with settings files, i have an habit of unintentionally breaking everything when i do >.<

[Ivaar]

I just enabled the commented code, but I set default to true, because default text color is white. You can change that to false delete settings.xml and reload

[Ivaar]

FYI you can change the default text color and bg color in the settings file, latest version uses a slightly grayed background instead of the old all black.

[rpherbig]

@Ivaar I've just started playing FF11 and find skillchains absolutely wonderful. Has there been any progress towards getting it into the Windower repo to make installation easier?