Ivaar / Windower-addons

FFXI Windower addons
70 stars 108 forks source link

Add-on: AutoDNC #29

Closed Ghostthief closed 4 years ago

Ghostthief commented 4 years ago

Add-on: AutoDNC getting stuck near "no foot rise" section keeps saying "Unable to use ability" "Already reached max finishing moves" then repeats "feather step" and Presto never does flourish to WS

Seems like a great Add-on if cleaned up sadly I don't have the skill to.

Please take a look.

Ivaar commented 4 years ago

Hmmm, sounds like your gearswap is cancelling it and printing that message. It should use CF before WS, provided you have a step available. Its also designed to spam steps/flourishes on cooldown for auto-dynamis staggering. That said I now realize my local copy is different and fixes proc commands. I will push those changes now. Before I go dust of DNC, can you confirm you were at your max steps when receiving that message?

Ivaar commented 4 years ago

Ah, I see that system message, however it did CF prior to ws when I had step available. Do //dnc active and make sure ja and ws is set to on, also confirm min/max ws hp and distance.

Ivaar commented 4 years ago

This is due to my using gain/lose buff event, which is a bit slower than checking buffs in memory or watching packets (if my memory serves). It doesnt get stuck on that line and moves to the following ability on next iteration. So I do not think that is the issue.

Ivaar commented 4 years ago

If it doesn't use ws at all I would have to guess its the distance check. I could enhance that by calculating it in euclidean space, however the exact formula used by the game is currently unknown.

Ivaar commented 4 years ago

This should fix the "unable to use" message, would you mind trying it out before I push changes? https://gist.github.com/Ivaar/a2da876b0f05f09a666b6dd34d98b358

It still spams enemy target job abilities when JA mode is enabled and it could waltz right after your CF if your hp drops below your configured threshold.

If you plan to use JA mode outside dyna you may want to modify that logic so it is not too spammy. I suppose I could implement a second JA mode, to preserve the logic behind stagger mode.

Ghostthief commented 4 years ago

On my way home now to try it .... Yes I had finishing move 5 (even though DNC is mastered)

Ghostthief commented 4 years ago

Just asking but does waltzpt section function?

Ghostthief commented 4 years ago

//dnc ws on made it fire ws but it never used climactic or reverse or wild for me

Ghostthief commented 4 years ago

This was on old version not the new one still driving home

Ivaar commented 4 years ago

Party waltzes should work, the setting to disable party slots was simply never implemented. Idk why party waltzes are more comprehensive, covering every tier. I was using this with motes gearswap libs back then change to appropriate waltz. That said self/party waltz could be combined into the waltz settings, maybe that's where I was going with it.

The buff adjustments I just made may possibly resolve your issue.

Ghostthief commented 4 years ago

getting ready to test now

Ghostthief commented 4 years ago

ok the tests worked .... But I can't turn waltzpt off

Ivaar commented 4 years ago

um, I believe it just needs to be added to dual_toggle

Ghostthief commented 4 years ago

Yep that fixed it thanks

Ghostthief commented 4 years ago

What is ws2 "Cyclone" used for?

Ivaar commented 4 years ago

That was going to be for ws stagger mode, never cared enough to flesh that out.

Ghostthief commented 4 years ago

Hmmm wonder If I am smart enough to make it into a self skillchain mode

Ghostthief commented 4 years ago

What could I do to send an echo of each event to the other chat window .... Hard to follow when in combat scroll

Ivaar commented 4 years ago

Run this script to find a chat mode (color) that prints to desired log window https://github.com/Windower/Lua/blob/dev/scripts/colortest.lua in game settings affect what modes are displayed in which log i.e. config>log>window X> and config>chat filters can block modes from displaying.

What do you mean each event?

Ghostthief commented 4 years ago

the flourishes and such

Ghostthief commented 4 years ago

step also go by so fast

Ivaar commented 4 years ago

I had this laying around, care to see if it works? https://gist.github.com/Ivaar/a5bd990110b4b12a21298fd0db789a72

Ghostthief commented 4 years ago

I'll give it a go in a few sure

Ghostthief commented 4 years ago

I loaded it but not sure what it's suppose to do ... It didn't fire anything that I saw

Ivaar commented 4 years ago

It creates a text box with step levels for current target, looks like it prints an addon message as well (likely for debugging). Doesn't track or log flourishes.

Ghostthief commented 4 years ago

I'll try it again in the morning when I'm off work but I saw no text box

Ghostthief commented 4 years ago

Okay I see it now YES it tracks steps and the lvl on them ... but I changed to X,Y in the settings xml file but it still puts it at 0,0

Ghostthief commented 4 years ago

I figured it out Edited x,y in actual LUA and it moved it... only problem is it doesn't seem to register when the debuff drops

Ivaar commented 4 years ago

I looked at it the other day and noticed it was unfinished and does not clear the effects properly. You can check out the debuffs addon to see if that has similar functionality. If not, I can possibly look into it this week.

Ghostthief commented 4 years ago

also noticed it doesn't track Featherstep only quickstep, Box step and Stutter step

Ghostthief commented 4 years ago

step_message = { [519] = 'Lethargic Daze', [520] = 'Sluggish Daze', [521] = 'Weakened Daze', [591] = 'Bewildered Daze', } that should fix that minor problem

Ghostthief commented 4 years ago

well think it will need more at the bottom but yeah

Ivaar commented 4 years ago

I updated steps.lua, misc issues should be resolved and it now displays a timer and if you are the actor it will account for job points.

Ghostthief commented 4 years ago

oh nice this works great

Ghostthief commented 4 years ago

thanks a bunch you got AutoDNC working awesome and now Steps is a second addition to your awsomeness!