IvanCraft623 / RankSystem

An amazing Rank and Permissions Manager. The best ranks manager for PocketMine-MP.
Apache License 2.0
42 stars 16 forks source link

Changing ranks #11

Closed ParadoxPlays closed 2 years ago

ParadoxPlays commented 2 years ago

I set my rank to Admin but now when I try setting it to default rank it doesn't show in chat that I'm newcomer Screenshot_20220603-233951_Minecraft

ParadoxPlays commented 2 years ago

Going to guess this is the multi rank per user support. I would suggest that this should be toggable in config because this would get very annoying.

ParadoxPlays commented 2 years ago

Also make it so we can just set what ranks higher ranks inherit, having multiple ranks per user would get very confusing after some time.

IvanCraft623 commented 2 years ago

Also make it so we can just set what ranks higher ranks inherit, having multiple ranks per user would get very confusing after some time.

You must remove the Admin rank, this is because this plugin supports multiple ranks at once.

NJMD13 commented 2 years ago

I have a similar problem.

When setting the Guest rank as Default, in Minecraft if the chat appears as Guest but the permissions are not given and I already checked the configuration of the ranks.yml and it is fine, but in the database it does not appear that the user has the rank .

xqwtxon commented 2 years ago

I have a similar problem.

When setting the Guest rank as Default, in Minecraft if the chat appears as Guest but the permissions are not given and I already checked the configuration of the ranks.yml and it is fine, but in the database it does not appear that the user has the rank .

That is depending when player is op, and you have been /deop ,you will removed some permissions, i think, the ranks should be synched when changing like /op and /deop

or your plugin has following concepts:

permissions:
       test.perms:
              default: op

or it might be the mysql problems, try to reproduce it on sqlite.

xqwtxon commented 2 years ago

I set my rank to Admin but now when I try setting it to default rank it doesn't show in chat that I'm newcomer Screenshot_20220603-233951_Minecraft

same thing, this plugin supports multiple ranks. If you have already ranks like admin, it would addition the another rank. Try to remove the admin rank to remove permissions.

NJMD13 commented 2 years ago

I think I didn't know how to make myself understood (I apologize).

The Guest rank is configured as the default rank (that is, it is given to all players who enter the server), but even if the Guest rank has the permissions [pocketmine.command.transferserver and pocketmine.command.say] they cannot use those commands.

To make the permissions work for them, I need to remove and re-give them the Guest rank so they can run the commands.

I apologize again, if I did not understand myself again, but I have never made myself understood well.

xqwtxon commented 2 years ago

I think I didn't know how to make myself understood (I apologize).

The Guest rank is configured as the default rank (that is, it is given to all players who enter the server), but even if the Guest rank has the permissions [pocketmine.command.transferserver and pocketmine.command.say] they cannot use those commands.

To make the permissions work for them, I need to remove and re-give them the Guest rank so they can run the commands.

I apologize again, if I did not understand myself again, but I have never made myself understood well.

for fast reading: if players join, the default ranks current permission would give them.

IvanCraft623 commented 2 years ago

I think I didn't know how to make myself understood (I apologize).

The Guest rank is configured as the default rank (that is, it is given to all players who enter the server), but even if the Guest rank has the permissions [pocketmine.command.transferserver and pocketmine.command.say] they cannot use those commands.

To make the permissions work for them, I need to remove and re-give them the Guest rank so they can run the commands.

I apologize again, if I did not understand myself again, but I have never made myself understood well.

Reproduced

xqwtxon commented 2 years ago

I think I didn't know how to make myself understood (I apologize). The Guest rank is configured as the default rank (that is, it is given to all players who enter the server), but even if the Guest rank has the permissions [pocketmine.command.transferserver and pocketmine.command.say] they cannot use those commands. To make the permissions work for them, I need to remove and re-give them the Guest rank so they can run the commands. I apologize again, if I did not understand myself again, but I have never made myself understood well.

Reproduced

maybe we can make onJoin() in event listener to sync ranks?

IvanCraft623 commented 2 years ago

Fixed on d45c1ef351cdd36ab717de10d003831dde2c3a3f