IvanCraft623 / RankSystem

An amazing Rank and Permissions Manager. The best ranks manager for PocketMine-MP.
Apache License 2.0
42 stars 16 forks source link

Fix #26 & should fix #31 #32

Closed xxAROX closed 1 year ago

xxAROX commented 1 year ago

Changes:

IvanCraft623 commented 1 year ago

Thanks for the PR, however this solution will not be sufficient, the best alternative would be to reload the session data when the player re-logs in.

Your solution is to remove the session when the player exits the server, which will partially solve the problem, but if you load the data when the player is offline (for example using the /ranks userinfo command), the issue will still occur.

xxAROX commented 1 year ago

I fix it when I'm home, the function to reload session is Session->loadUserData() right?

xxAROX commented 1 year ago

Btw great job with this plugin 👍😁

xxAROX commented 1 year ago

@IvanCraft623 is this acceptable?

xxAROX commented 1 year ago

never mind this dosn't work