Closed jbinda closed 4 years ago
My only concern with this is that it would increase the scope of this action. Something similar that I thought of could be automatically requesting reviews based on labels, but these things start to extend it beyond just a labeler.
Do you have an example of what a JSON config would look like for this feature? That's another concern - it may make configs more complicated.
As an alternative, you could combine this with another action such as https://github.com/yogevbd/enforce-label-action, which will block merging based on which labels are applied.
As for this specific use case (WIP PRs), Github has a draft feature which already prevents merging (although there are some problems - you can't turn an existing, non-draft PR into a draft PR, and some people have complained about it being too hard to distinguish drafts in the PR list).
As an alternative, you could combine this with another action such as https://github.com/yogevbd/enforce-label-action, which will block merging based on which labels are applied.
Yes I thought about something when you set label in e.g. DO_NOT_MERGE
then the merging wont be able.
This one is nice to have I think because there is other action that you can pick. However still it's nice to have in one place :)
I’ve thought about it, and I’m going to mark this wontfix for now, for two reasons:
isDraft
condition would be for applying labels other than a WIP status.I have created a revisit
label (might rename it later), to remember to revisit these features if the scope of the project changes.
Again, thank you for the suggestion!
Is your feature request related to a problem? Please describe. No
Describe the solution you'd like Currently I'm using github wip app to make check task in "ongoing" state.
I wonder if we can provide some similar feature to
super-labeler
( in e.g fail one of the task if the WIP status is applied)