IvanFon / super-labeler-action

A superpowered issue and pull request labeler for Github Actions.
GNU General Public License v3.0
22 stars 12 forks source link

Allow to add fallback if no label match occurs #13

Open jbinda opened 4 years ago

jbinda commented 4 years ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Abe able to pass fallback if the is no match for label when opening PR/issue (default label can be need_triage or something like that

jayu commented 4 years ago

Hi folks, how about the following syntax:

{
   labels:{},
   pr : {},
   pr_fallback : "", // name of label to fallback, eg. needs triage
   issue: {},
   issue_fallback : "" // name of label to fallback, eg. needs triage
}

I would suggest to not set any fallback label if not explicitly specified.

jbinda commented 4 years ago

pr_fallback : "", // name of label to fallback, eg. needs triage

Do you think it should be one label or an Array ?

Also I wonder if apart of config we do not want some flag in yml to disable fallback as well. I think about the use case when I do not want to change config but e.g temporary disable fallback

jayu commented 4 years ago

Array seems to be more reasonable and future proof, you are right. Regarding the second sentence, I'm not sure if it is really needed

IvanFon commented 4 years ago

Also I wonder if apart of config we do not want some flag in yml to disable fallback as well. I think about the use case when I do not want to change config but e.g temporary disable fallback

I don’t think this is necessary - it doesn’t seem like a very common scenario, and since the config is checked into the repo it’s easy to revert it after a temporary change. I think having configuration specified in multiple places would increase complexity too much.

Array seems to be more reasonable and future proof, you are right.

Agreed 👍

jayu commented 4 years ago

I'm working on this :)