search

IvanKirpichnikov / aiokeycloak

aiokeycloak - asyncio keycloak python client
Apache License 2.0
5 stars 3 forks source link

add imports in `__init__.py` #7

Open IvanKirpichnikov opened 2 weeks ago

hntuan7684 commented 2 weeks ago

Can you give me more details . So that I can work on it .

hntuan7684 commented 2 weeks ago

https://github.com/hntuan7684/aiokeycloak.git, if you are unsatisfied, please give me more suggestions

IvanKirpichnikov commented 2 weeks ago

Can you give me more details . So that I can work on it .

Hello. need to add to aiokeycloak/__init__.py add KeycloakClientFactory and KeycloakClient imports. In (types | methods)/__init__.py needs to add imports of all types and methods. You need to use absolute paths and the dander variable __all__.

It's going to happen, something like that.

from aiokeycloak.client import KeycloakClient
from aiokeycloak.factory import KeycloakClientFactory

__all__ = [
    "KeycloakClient",
    "KeycloakClientFactory",
]
IvanKirpichnikov commented 2 weeks ago

https://github.com/hntuan7684/aiokeycloak.git, if you are unsatisfied, please give me more suggestions

I didn't notice that you specified your repository. Create an extraction request. I'll point out the mistakes.

IvanKirpichnikov commented 2 weeks ago

https://github.com/hntuan7684/aiokeycloak.git, if you are unsatisfied, please give me more suggestions

i created pull request. check code review.

hntuan7684 commented 1 week ago

I created pull request check code help me