search

IvanLeonenko / WPFGrowlNotification

Lightweight growl notifications for WPF project.
62 stars 35 forks source link

Some change requests, looking to implement #1

Open killnine opened 10 years ago

killnine commented 10 years ago

Hi Ivan,

Thanks for the really neat project!

I was thinking of making some minor changes to the project and wasn't sure if you'd be interested in integrating them if I made a pull-request.

  1. It looks like the GrowlNotifications class has a typo (GrowlNotifiactions, currently)
  2. With the existence of MetroUI and MahApps.Metro for WPF, along with resources like Modern UI Icons, I'd like to support PathGeometry icons rather than rasterized icons.
  3. I'd also like to implement a mechanism to position the notifications relative to the Parent window rather than the desktop (as an option).
  4. I'm also interested in making the example in MVVM terms. Not sure about this, yet.
  5. Also, it'd be neat if this was a NuGet package, though I have never done that before.

Let me know if you have any thoughts. Thanks again for your work!

IvanLeonenko commented 10 years ago

Hello,

Thank you, of course you can make a pull-request, I'll review and integrate.

When I have time I can make a nuget package and may be upgrade the project.

On Thu, Jul 3, 2014 at 3:34 AM, killnine notifications@github.com wrote:

Hi Ivan,

Thanks for the really neat project!

I was thinking of making some minor changes to the project and wasn't sure if you'd be interested in integrating them if I made a pull-request.

  1. It looks like the GrowlNotifications class has a typo ( GrowlNotifiactions, currently)
  2. With the existence of MetroUI and MahApps.Metro for WPF, along with resources like Modern UI Icons http://modernuiicons.com/, I'd like to support PathGeometry icons rather than rasterized icons.
  3. I'd also like to implement a mechanism to position the notifications relative to the Parent window rather than the desktop (as an option).
  4. Also, it'd be neat if this was a NuGet package, though I have never done that before.

Let me know if you have any thoughts.

— Reply to this email directly or view it on GitHub https://github.com/IvanLeonenko/WPFGrowlNotification/issues/1.

Thank you, Ivan Leonenko

killnine commented 10 years ago

I completed (1) and (2) and made a PR. Any thoughts on how I might be able to avoid requiring code-behind changes would be appreciated. I tried converting to a custom control but ran into issues when trying to template because the current solution is based on creating a whole new Window (can't create a control template that uses a Window).

I'd love to see this added as an extension package to the MahApps.Metro project and hope to continue to help where I can.