IvanMathy / Boop

A scriptable scratchpad for developers. In slow yet steady progress.
https://boop.okat.best
MIT License
3.84k stars 356 forks source link

Supporting SF Symbols identifiers for script icons #273

Closed nd-net closed 3 years ago

nd-net commented 3 years ago

Just a small change that also supports SF Symbols identifiers as script icon names:

I did not change the .lowercased() in the initialisation of Script since SF Symbols also uses lowercase-only identifiers.

The documentation has been updated appropriately.

Overview of the new functionality

script-with-sfsymbol-identifier Specifiying an SF Symbol name in a script

boop-ui-with-sfsymbol Selection

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nd-net commented 3 years ago

The automatic build on bitrise fails because it's using Xcode 11.7; the NSImage(systemSymbolName:accessibilityDescription:) API is only available on macOS 11/Xcode 12 and above.

IvanMathy commented 3 years ago

Well, this is ridiculously cool. Thanks for the PR!

I updated the CI system's Xcode version so it'll build okay now 👍

grzesimaj-74 commented 3 years ago

Dlaczego to jest tylko do Apple App Store? Ja chcę do Microsoft Lumia lub Surface. Nigdy mnie nikt nie namówi do przesiadki na Android lub Apple. Mam wiarygodne informacje których nie mogę publicznie udostępnić. Android i Apple działają wspólnie na nie korzyść dla firmy Microsoft.