Open HansCronau opened 3 years ago
Several options to implement needed intent. The code is a bit messy though. The Material Files developer can have a look at: https://github.com/IvanVolosyuk/diskusage/blob/master/app/src/main/java/com/google/android/diskusage/DiskUsage.java#L342
On Mon, Jul 19, 2021 at 6:54 PM Hans Cronau @.***> wrote:
DiskUsage already integrates with OI FileManager and Solid Explorer. If neither are installed, upon pressing the "sʜᴏᴡ" button, DiskUsage will display the following prompt: [image: DiskUsage - Missing compatible file manager] https://user-images.githubusercontent.com/977860/126130969-a4a5ee00-fc8a-4b6e-b755-f697743db0e3.png
I asked https://github.com/zhanghai/MaterialFiles/issues/512 the developer of my favourite file manager, Material Files https://github.com/zhanghai/MaterialFiles. They had a look at DiskUsage's code, and think integration should be supported on Material Files' end.
What would be required to make these amazing apps (both available on F-Droid, unlike OI FileManager and Solid Explorer) integrate with each other?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/issues/72, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HLRIE3EL2P32ISVJJ3TYPR3NANCNFSM5ATH7HFQ .
I'm seeing that DiskUsage is trying ACTION_VIEW
with inode/directory
at: https://github.com/IvanVolosyuk/diskusage/blob/f7ec279f7fa25086458ac572b1ad9d10cca44a57/app/src/main/java/com/google/android/diskusage/DiskUsage.java#L332
And that seems already supported by Material Files: https://github.com/zhanghai/MaterialFiles/blob/d85fc254e8cd9ad2d0cf44a9a919344c04e531ea/app/src/main/AndroidManifest.xml#L54
Is there any additional checks in DiskUsage before it launches that intent?
The last release of DiskUsage was done quite a while ago. Looks like the last release version of DiskUsage doesn't include this changes: https://github.com/IvanVolosyuk/diskusage/blob/64479bf235365b7818cc3bfb3a635fd687028ae6/app/src/main/java/com/google/android/diskusage/DiskUsage.java
On Tue, Jul 27, 2021 at 4:42 AM Hai Zhang @.***> wrote:
I'm seeing that DiskUsage is trying ACTION_VIEW with inode/directory at: https://github.com/IvanVolosyuk/diskusage/blob/f7ec279f7fa25086458ac572b1ad9d10cca44a57/app/src/main/java/com/google/android/diskusage/DiskUsage.java#L332
And that seems already supported by Material Files: https://github.com/zhanghai/MaterialFiles/blob/d85fc254e8cd9ad2d0cf44a9a919344c04e531ea/app/src/main/AndroidManifest.xml#L54
Is there any additional checks in DiskUsage before it launches that intent?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/issues/72#issuecomment-886938504, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HL3QTS7F6Z3Q6AQPZTTZWUB3ANCNFSM5ATH7HFQ .
@IvanVolosyuk Would be great to see a new, updated release of DiskUsage (maybe also mentioning Material Files as one of the suggested file explorers).
DiskUsage already integrates with OI FileManager and Solid Explorer. If neither are installed, upon pressing the "sʜᴏᴡ" button, DiskUsage will display the following prompt:
I asked the developer of my favourite file manager, Material Files. They had a look at DiskUsage's code, and think integration should be possible. In fact, they think integration should already be supported.
Would you kindly have a look in the other thread and explore what would be required to make these amazing apps (both available on F-Droid, unlike OI FileManager and Solid Explorer) integrate with each other?