Closed WhiredPlanck closed 1 year ago
I don't think I can rename it on play store.
On Sat, 25 Mar 2023, 11:43 WhiredPlanck, @.***> wrote:
This PR is going to rename the application id, because the current com.google.android.diskusage looks like a Google official product, and it may cause a misunderstanding, so I rename it to com.volosyukivan.diskusage .
This PR is based on #79 https://github.com/IvanVolosyuk/diskusage/pull/79 , you may want to merge it first.
You can view, comment on, or merge this pull request online at:
https://github.com/IvanVolosyuk/diskusage/pull/80 Commit Summary
- a663dbe https://github.com/IvanVolosyuk/diskusage/pull/80/commits/a663dbe6e49b1b7e62028a42d96b0d86efe1fa88 Drop protobuf plugin
- 108f0d6 https://github.com/IvanVolosyuk/diskusage/pull/80/commits/108f0d63899976450a6dcc96ec519a9da1f177b0 Specify curtain ndk version
- 47f870e https://github.com/IvanVolosyuk/diskusage/pull/80/commits/47f870edf1b6f0e478115bdde6f480ac01fa85c1 Update gradle to v8.0.2
- a820bfe https://github.com/IvanVolosyuk/diskusage/pull/80/commits/a820bfe0f8150c1359f9e9e95cfe1f7eff0babd7 Remove deprecated jcenter repository
- 6d2224c https://github.com/IvanVolosyuk/diskusage/pull/80/commits/6d2224cca1d5de7d773b295562a3152acf9865d4 Update gradle build plugin to v7.4.2
- 7014e92 https://github.com/IvanVolosyuk/diskusage/pull/80/commits/7014e92042e23838db4fbf06089fbe28cc1489dc Update kotlin version to v1.8.0
- 768d6db https://github.com/IvanVolosyuk/diskusage/pull/80/commits/768d6db939bd618a43c64a97e02ae08c82520f8a Update gradle options and api usages
- 1efd23b https://github.com/IvanVolosyuk/diskusage/pull/80/commits/1efd23b127289412392cca950251717b41f09093 Update dependencies
- 21e5b42 https://github.com/IvanVolosyuk/diskusage/pull/80/commits/21e5b427758a8de3fdcfa87f481af79eb07004cb Update compile sdk and build tools version to 33
- 01fb8ab https://github.com/IvanVolosyuk/diskusage/pull/80/commits/01fb8ab578893e0e6db5b693dfe0d6550003df90 Replace custom logger with Timber logging library
- 1ddeb05 https://github.com/IvanVolosyuk/diskusage/pull/80/commits/1ddeb054564374a0ae4af1750307d6f5feca1673 Remove unnecessary TargetAPI annotations
- 62ffc17 https://github.com/IvanVolosyuk/diskusage/pull/80/commits/62ffc174fd6687eefaf3e2ca8f12c357d9913653 Rename application id
File Changes
(69 files https://github.com/IvanVolosyuk/diskusage/pull/80/files)
- M app/build.gradle https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9 (35)
- M app/src/main/AndroidManifest.xml https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-7fa6aef292187a049f7a4d6060d8df3ba212d838789c78940bd363344b1c38cd (2)
- D app/src/main/java/com/google/android/diskusage/DiskUsageApplication.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-6a40188446d8fd4bba3f73bc239b67471d0c732f9d549b900e7aefe2f206a907 (16)
- D app/src/main/java/com/google/android/diskusage/datasource/AppStats.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-5411e4b7e02bda73eea43d552798e1bcd696f728da1dd1ce0c6fc1df52259774 (20)
- D app/src/main/java/com/google/android/diskusage/utils/Logger.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-0c80b769660b2137fa3ab17ceb70afb364899483913bf816ea5c131dcbd63b68 (117)
- A app/src/main/java/com/volosyukivan/diskusage/DiskUsageApplication.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-9ff0a9e162fcf05cb78d9a982791a3420457bb0a4c961187a6d06aa0ea4af8a1 (28)
- R app/src/main/java/com/volosyukivan/diskusage/core/NativeScanner.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-d3e0bb1c2c7846570033898743e6dcc9f81e35e5d6ead5a53ce63c11abec6c2a (32)
- R app/src/main/java/com/volosyukivan/diskusage/core/Scanner.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-3a8c29087235b9fc0b51fe9b93f90fa2a02abea826aab19e7e4a69f91dbd6137 (28)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/AppInfo.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-db0bcaef5a4c52e2359aee3928deb264187fe515cc71f0d898aa203772ca61e1 (6)
- A app/src/main/java/com/volosyukivan/diskusage/datasource/AppStats.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-063b4c8f638aa0bddfcefb7ad7b55d4850a6fe769aa6eddfd9680f5813ae7cdc (12)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/AppStatsCallback.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-11838265007548174eea1af0bbef313e6270bf279ca5e5d24d8959169060ab10 (2)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/DataSource.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-abaceeba44b8d4d391e908706697fb04729ffcd7e65f36444b25d653ec6166dc (13)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/LegacyFile.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-03184d2c4af7c5ec0eda416ad88a4f654149b4998b26b7e5acb323e67aec196e (2)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/PkgInfo.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-576535078eed28e05f27d441325dcf6aba5e99221bc15e4d9255da759bbb76ed (2)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/PortableFile.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-45e4a14b2fceb323927469b21b6373fb2af518854a4157262553014d82fb49cb (8)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/SearchManager.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-6b9ea81ea4bb0139ad250d1e4c03616c874bcf589c4bed241959760bf09136d2 (8)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/StatFsSource.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-f1a4df3546919df400b061d59190069060dd5e5a577f01b6371ea6832ced2610 (12)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/AppInfoImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-66552c4414702e82e348988a39be003b385ec4bd701747a0b81ed425f6d6797d (7)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/AppStatsImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-f72e065e025b005a4531e168f2d7085e2994b9ec7b2aaa8af97ab77d0dd32427 (11)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/DefaultDataSource.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-5aa345c61ab2613b0b841a31d5280b67b1b8c0282075a375af6cf6be4feb7f84 (17)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/LegacyFileImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-b261a57e739e9551a51522e94e7933c6e737e4ab75dc3a81d3f32bbfc6d508b7 (4)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/NativeScannerStream.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-d85a95df2eeb1b9d5d5f4e0cabf3d3de4e6c7044244dc6224839813bd07257a7 (6)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/PkgInfoImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-b7aee76563a582b44a0445e3e84e18042d3b6a9ae3156a06cd075b7854772b55 (6)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/PortableFileImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-6c8eedc28fea7fef7d5b562128d574f271e25ac040319a1b9fd00482388be065 (13)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/StatFsSourceImpl.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-78b30f78893d0448c040118cba55af9e8dc5e01b41c00421e17e74d9556c274d (13)
- R app/src/main/java/com/volosyukivan/diskusage/datasource/fast/StreamCopy.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-8dcc367b03eca1d28eab2f3856db788f095b05c991fc490544295201cddc7d2d (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/Apps2SDLoader.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-ff2c75023913403ab8d0e24725b60e71aa1b4c5c236c593d45ae5b604f028049 (20)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/BackgroundDelete.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-315ebc07020fa4ef98401d79610c824cb0819e76902a6d6e5981436b9b64f917 (28)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemEntry.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-201603637653f6e3bf070bc2419a177aa379e50229329e9121e16e9e247f1ba1 (14)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemEntrySmall.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-179953b8a3f81454b2f0bd0750884b4cd5e316fb469122537bb289e212d6c29e (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemFile.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-86450f3db4feb6710902098d1e9609c3b13b2ec39b65eea2917427ddf2bc7c7e (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemFreeSpace.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-c0ee8a1999c12ed7aef8d6e95577bfa63dcc161e23cc0c0ee039c01ac700920f (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemPackage.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-0b13149cb0124217a2d54219921b6c4a8e5538ca3929521968e7720b51ae2250 (10)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemRoot.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-ee3643f31137c16378a3ba1ddc7edd11be6e944879f9887ffdafeb2740663f2a (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemSpecial.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-233bcff64145d570489840775a902f68bda901df77b31cffa9cd8068f98521ca (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemSuperRoot.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-9f74cf7314cae52382fe2dc2332bc3d0731fddbbd7a7e42f2a94c92ec747cbff (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/entity/FileSystemSystemSpace.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-db384cf3038505f3db2636ffa2ef11101627467efc8cf757af34f368267f3d86 (2)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/mnt/MountPoint.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-88eb73dbe3168e59c9269d9128b8cba3f0c4f12cc155a8383932f7d39686ca7f (16)
- R app/src/main/java/com/volosyukivan/diskusage/filesystem/mnt/RootMountPoint.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-41f704be5ab759c2379476a6fc088e5b7ded4e9b8f53982c379314b2bffa30c3 (12)
- R app/src/main/java/com/volosyukivan/diskusage/opengl/AbstractRenderingThread.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-1fe2114fa25dbfe9be168fca282cd3df35004facf9fcea86e7c554680337f217 (18)
- R app/src/main/java/com/volosyukivan/diskusage/opengl/DrawingCache.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-aaffaf2eb0d5a280a5341047daba365648a46063bd163d0b35f3ea9b7bd140cc (6)
- R app/src/main/java/com/volosyukivan/diskusage/opengl/FileSystemViewGPU.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-db499b696e98532095763de0cf93c0d4ab460bd9a21a83279e0a30c00c6a3933 (16)
- R app/src/main/java/com/volosyukivan/diskusage/opengl/RendererManager.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-8d89b14f27b3fed48cef0b00c6c411e80de3c500e58faf5b661a8c131b2a89e3 (10)
- R app/src/main/java/com/volosyukivan/diskusage/opengl/RenderingThread.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-6b7afbd3ff6aa25c25f9582d5adcd92814ef8e964e2e7aa1f63b9c715a9ef39c (20)
- R app/src/main/java/com/volosyukivan/diskusage/ui/Cursor.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-b79baed9282c381a95e59a87d5d79cbd72f7f0bbfa08fb11358fca4bab7ca89d (4)
- R app/src/main/java/com/volosyukivan/diskusage/ui/DeleteActivity.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-1b31e3699a007820ffa664049f51aa3e58c93165656fef1a622e5e11216914cf (14)
- R app/src/main/java/com/volosyukivan/diskusage/ui/DiskUsage.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-b0ab8ce468faacf36448b510455d3f8d550661ac1379d819c181bdc7b664e16c (60)
- R app/src/main/java/com/volosyukivan/diskusage/ui/DiskUsageMenu.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-e1f3f7bcfe2cf844dac46e9a257a7fb0e2a44a35ca8bc76b38dcd6ca01d84a4d (18)
- R app/src/main/java/com/volosyukivan/diskusage/ui/DiskUsageMenuHoneycomb.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-aac28501197ec64c76283f8154ce9b7e4981fae457b7d91b4a708dd0dd1cec25 (12)
- R app/src/main/java/com/volosyukivan/diskusage/ui/FileSystemState.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-16bd2c07501c9ff47242073dae4c6941e5d4acfef6f081aa68e70c7c28d9693d (30)
- R app/src/main/java/com/volosyukivan/diskusage/ui/FileSystemViewCPU.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-89880e6678021aa962cdfe7f0dfc55cb1fbbf3fa2124939d780acc1079913057 (10)
- R app/src/main/java/com/volosyukivan/diskusage/ui/LoadableActivity.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-63ea79c09f7506619e7f9f93cf0319a23fb627e4fc645ea6a167b8a9afb9c8ef (40)
- R app/src/main/java/com/volosyukivan/diskusage/ui/PermissionRequestActivity.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-7eee7fdc229c0621aaf9a615a5ede1ef3981a9649bee50a5986c423937a2c671 (8)
- R app/src/main/java/com/volosyukivan/diskusage/ui/SelectActivity.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-4c3ce53f91c06b4d3a221b65a84bd561c085b5440ba5c656617a51aec053593d (20)
- R app/src/main/java/com/volosyukivan/diskusage/ui/ShowHideMountPointsActivity.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-2477b8fff514c553ed37ec12d7da5d67f63d59379e534116a0aa09a08468e9c4 (12)
- R app/src/main/java/com/volosyukivan/diskusage/ui/common/AdaptiveTextView.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-ebcbbd8baaa483ccf93dafbc305701a56b2d863df3e439d3b445613c863dead2 (2)
- R app/src/main/java/com/volosyukivan/diskusage/ui/common/FileInfoAdapter.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-592a6485a30e51b44d9df9d43b6cfe5b121704c15445cf5c44ef8dbfa52adcf2 (10)
- R app/src/main/java/com/volosyukivan/diskusage/ui/common/ScanProgressDialog.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-c3f0c0c0042a51606a7d7f459fa968c2bc50776b4a32b6b8f821e3718776328f (6)
- R app/src/main/java/com/volosyukivan/diskusage/utils/AppHelper.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-b824c90a97ddb40dca794ccadd7df46d18d155bbc07638450e7d0e0327d84b7a (4)
- R app/src/main/java/com/volosyukivan/diskusage/utils/AppIconCache.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-650df2eee473cf389b676b4b1c8706c3df15e60b3651758b8f086fd6aa50f998 (4)
- R app/src/main/java/com/volosyukivan/diskusage/utils/DeviceHelper.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-a1c0ff719ef15d1611f8b61504a53e5ebbffcab297dadda6b3f37d72e917b638 (2)
- R app/src/main/java/com/volosyukivan/diskusage/utils/DeviceInfo.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-e1f248c1f1ca6ff444b9ccfae31c669a9d391de4da360558658ed2502bc946d9 (4)
- R app/src/main/java/com/volosyukivan/diskusage/utils/IOHelper.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-56aa13898d364db2eae9804d7c39768fbfc9f067a043b4462c1f2a8e8823c6bc (2)
- R app/src/main/java/com/volosyukivan/diskusage/utils/MimeTypes.java https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-6c407053a0c504283d05d0cc6d3f75fc26b070051df87f4c44d50cbeefe7e6f0 (4)
- R app/src/main/java/com/volosyukivan/diskusage/utils/PathHelper.kt https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-7e85ed5f4c3ea29ac4351c86a738693f3c339cd8c87108115110bb41116f7d49 (4)
- M app/src/main/res/layout/delete_view.xml https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-65244a2f427749159a365bd29771fff78426b93241d995b243378b5d08db5e36 (2)
- M build.gradle https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7 (24)
- M gradle/wrapper/gradle-wrapper.properties https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-40640fe1078ece83d7ea8fb67daacd77923a86d13447baf9769660b3b46f2ece (2)
- M settings.gradle https://github.com/IvanVolosyuk/diskusage/pull/80/files#diff-7f825392aa37acd1cee0c2e7b9bb7366ad6eac64f3e6cdd816e156bcb69d30de (19)
Patch Links:
- https://github.com/IvanVolosyuk/diskusage/pull/80.patch
- https://github.com/IvanVolosyuk/diskusage/pull/80.diff
— Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/pull/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HKZTPQRREL2TZ2J7ULW5Y5SXANCNFSM6AAAAAAWHFW4ZY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I don't think I can rename it on play store.
Hm, have you lost control of the Google Play version ... ? Or other reason?
I think google play doesn't allow you to change package version for an app, but I might be mistaken. Haven't tried that.
On Sat, Mar 25, 2023 at 2:21 PM WhiredPlanck @.***> wrote:
I don't think I can rename it on play store.
Hm, have you lost control of the Google Play version ... ? Or other reason?
— Reply to this email directly, view it on GitHub https://github.com/IvanVolosyuk/diskusage/pull/80#issuecomment-1483702975, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXQ6HPKPGLEM2EFJUP4CETW5ZQDVANCNFSM6AAAAAAWHFW4ZY . You are receiving this because you commented.Message ID: @.***>
I think google play doesn't allow you to change package version for an app, but I might be mistaken. Haven't tried that.
It doesn't matter. I just try to do it. If Google Play doesn't allow us or it's too much trouble to do that, just close this PR.
This PR is going to rename the application id, because the current
com.google.android.diskusage
looks like a Google official product, and it may cause a misunderstanding, so I rename it tocom.volosyukivan.diskusage
.This PR is based on #79 , you may want to merge it first.