Accept an initial condition as argument for solve()

IvanYashchuk / firedrake-ts

The firedrake-ts library provides an interface to PETSc TS for the scalable solution of DAEs arising from the discretization of time-dependent PDEs.

MIT License

11 stars 4 forks source link

Accept an initial condition as argument for solve() #14

Closed salazardetroya closed 3 years ago

salazardetroya commented 3 years ago

This makes the interface similar to TS and will make it easier for the integration with pyadjoint.

IvanYashchuk commented 3 years ago

Hey, Miguel! Thanks for opening this pull request!

PETSc SNES also takes a solution vector as an argument, however, in Firedrake the .solve method for the NonlinearVariationalSolver doesn't do that. I followed Firedrake's design for DAESolver. The Function objects that are passed to DAEProblem are used as initial conditions.

How does it simplify the integration with pyadjoint?

salazardetroya commented 3 years ago

Ok in that case I need to think about it.