search

IvanYashchuk / firedrake-ts

The firedrake-ts library provides an interface to PETSc TS for the scalable solution of DAEs arising from the discretization of time-dependent PDEs.
MIT License
11 stars 4 forks source link

Compatibility with Firedrake_20220411.0 #17

Closed jcallaham closed 2 years ago

jcallaham commented 2 years ago

The tests are currently failing - looks like firedrakeproject/firedrake#1983 refactored assemble.py, including removing the assemble_type kwarg.

Initial function: https://github.com/firedrakeproject/firedrake/blob/1e0f9ed8ed9e6ea1a627471730dda0bddb7fd1fa/firedrake/assemble.py#L134-L169

Current version: https://github.com/firedrakeproject/firedrake/blob/a77a4996d61da8f8b5710589e1a754357a79886f/firedrake/assemble.py#L223-L284

This conflicts with things like the assemble_residual function in firedrake_ts.solving_utils._TSContext, which hardcodes assemble_type as an argument to assemble: https://github.com/IvanYashchuk/firedrake-ts/blob/879935387e486870308101e6d1bd8f393c762bea/firedrake_ts/solving_utils.py#L189-L196.

IvanYashchuk commented 2 years ago

Hey Jared! Thanks a lot for filing an issue and submitting a fix! I'll review the proposed changes later today.

IvanYashchuk commented 2 years ago

Fixed in https://github.com/IvanYashchuk/firedrake-ts/pull/18. Thanks a lot!

jcallaham commented 2 years ago

No problem. This is a great package, by the way - thanks for keeping it going!