IvanYashchuk / firedrake-ts

The firedrake-ts library provides an interface to PETSc TS for the scalable solution of DAEs arising from the discretization of time-dependent PDEs.
MIT License
11 stars 4 forks source link

Compatibility with 20220411.0 #18

Closed jcallaham closed 2 years ago

jcallaham commented 2 years ago

Fixes for compatibility with the current Firedrake/PyOP2 versions - see #17.

Aside from the assembly_type kwarg, the rest of the call signature in firedrake.assemble looks the same to me, so I think just removing the kwarg works. That fixed 6/7 of the failed tests.

The other test failure (examples/cahn-hillard.py) is related to an updated interface to par_loop in PyOP2. I don't totally understand the changes to par_loop, but seems like a simple fix is to move the user_code to the kernel_kwargs dict. All the tests are now passing with my configuration.