search

IvanYashchuk / firedrake-ts

The firedrake-ts library provides an interface to PETSc TS for the scalable solution of DAEs arising from the discretization of time-dependent PDEs.
MIT License
11 stars 4 forks source link

Reordering imports #8

Closed salazardetroya closed 4 years ago

salazardetroya commented 4 years ago

per firedrakeproject/firedrake#1800

codecov-commenter commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   69.27%   69.84%   +0.56%     
==========================================
  Files           3        3              
  Lines         371      378       +7     
  Branches       65       65              
==========================================
+ Hits          257      264       +7     
  Misses         82       82              
  Partials       32       32
Impacted Files Coverage Δ
firedrake_ts/ts_solver.py 80.71% <100.00%> (+1.01%) :arrow_up:
IvanYashchuk commented 4 years ago

That's a strange bug. Thank you for the PR!

wence- commented 3 years ago

We finally merged the necessary fixes to the firedrake installer to avoid this problem (in firedrakeproject/firedrake#1885) so hopefully module ordering is no longer as important.

IvanYashchuk commented 3 years ago

Thank you, Lawrence, for letting us know!