Ivaylo-Lafchiev / ValheimRecycle

Valheim mod for recovering crafting materials from crafted/upgraded items.
MIT License
1 stars 3 forks source link

Invalid parameter for Hearth & Home update, understood that this needs to be changed to INT - but that's based off some assistance elsewhere. I'm not a dev so cannot confirm. #6

Open snips86x opened 3 years ago

snips86x commented 3 years ago

https://github.com/Ivaylo-Lafchiev/ValheimRecycle/blob/7940c118a1bbd4e2f1aef1eaac1f95094d1d27c8/GameClasses/InventoryGui.cs#L142

Ivaylo-Lafchiev commented 3 years ago

I'll see if this is an easy fix, if not I may have to mark this mod as no longer supported.

snips86x commented 3 years ago

If you could, that would be amazing! I'm looking to understand how to do this myself but that's more longterm. Short term, your fix would be very welcome and appreciated.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Ivaylo Lafchiev @.> Sent: Monday, September 20, 2021 2:34:23 PM To: Ivaylo-Lafchiev/ValheimRecycle @.> Cc: snips86x @.>; Author @.> Subject: Re: [Ivaylo-Lafchiev/ValheimRecycle] Invalid parameter for Hearth & Home update, understood that this needs to be changed to INT - but that's based off some assistance elsewhere. I'm not a dev so cannot confirm. (#6)

I'll see if this is an easy fix, if not I may have to mark this mod as no longer supported.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Ivaylo-Lafchiev/ValheimRecycle/issues/6#issuecomment-922933323, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFNK3HWGGHHVA4XPN5HFBTUC4Z57ANCNFSM5EL5ON7A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

snips86x commented 3 years ago

If required, I can provide you details of where it's failing exactly but from the error I've been looking at, it starts at line 140

snips86x commented 3 years ago

I have a working version, do you want it? Am I able to distribute giving you credit or would you want to keep that? I know someone who might take the reins if you're not supporting it?

Ivaylo-Lafchiev commented 3 years ago

I have released a new update 2.0.0 that should address this. Please do not distribute versions of the mod without my consent. If anyone wants to contribute to the mod then they are welcome to raise an MR and I will try to help test/review, and give credit on Nexus mods as appropriate.

snips86x commented 3 years ago

So are you going to continue supporting it?

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Ivaylo Lafchiev @.> Sent: Monday, September 20, 2021 7:49:42 PM To: Ivaylo-Lafchiev/ValheimRecycle @.> Cc: snips86x @.>; Author @.> Subject: Re: [Ivaylo-Lafchiev/ValheimRecycle] Invalid parameter for Hearth & Home update, understood that this needs to be changed to INT - but that's based off some assistance elsewhere. I'm not a dev so cannot confirm. (#6)

I have released a new update 2.0.0 that should address this. Please do not distribute versions of the mod without my consent. If anyone wants to contribute to the mod then they are welcome to raise an MR and I will try to help test/review, and give credit on Nexus mods as appropriate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Ivaylo-Lafchiev/ValheimRecycle/issues/6#issuecomment-923187631, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFNK3D3BUEJHCLLFPETZFTUC564NANCNFSM5EL5ON7A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Ivaylo-Lafchiev commented 3 years ago

For now I will continue to update it when it breaks as long as it does not require an extensive rewrite. I don't plan to add any new features.