search

Ivshti / wcjs-prebuilt

Install pre-built WebChimera.js with bundled VLC for Electron
43 stars 21 forks source link

error on install #6

Closed heartnetkung closed 9 years ago

heartnetkung commented 9 years ago

[TypeError: Cannot read property 'platform of undefined'] This is due to the commit "1b7d07dd93585a68cfc1ecedf4b2ee6b63a84895"

To fix this, see https://github.com/heartnetkung/wcjs-prebuilt/commit/9337003c812460967bafd5d103a45f36d5791987

jaruba commented 9 years ago

@Ivshti your fast.. :))

Ivshti commented 9 years ago

Thanks @heartnetkung , it's now fixed

I'm thinking of reverting the commit however since I'm using env variables

bad @luigiplr :D

Seriously though, we should at least bump versions when making breaking changes

RSATom commented 9 years ago

Even if we are able use settings from package.json env variables still have a meaning...

Ivshti commented 9 years ago

Yep, definitely, env variables are always useful.

heartnetkung commented 9 years ago

btw u have a typo :)

//aquiring > acquiring
console.log('Aquiring:', downloadObject.name);
jaruba commented 9 years ago

btw u have a typo :)

sounds like the work of @luigiplr ..

@heartnetkung it's not his fault, he's italian..

lol

Ivshti commented 9 years ago

@jaruba he makes great pizza

Seriously though, I'm vetoing this discussion :D

luigiplr commented 9 years ago

:pizza: :dancer: :+1: