Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for android that you can either build or download from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.7k stars 631 forks source link

F-Droid #104

Open TechnologyClassroom opened 2 years ago

TechnologyClassroom commented 2 years ago

Will Ivy Wallet be added to F-Droid?

ILIYANGERMANOV commented 2 years ago

Hi @TechnologyClassroom why not? I'll add it! I just hope Google Login + Google Billing will still work.

roshavagarga commented 2 years ago

Hey Iliyan, you can find more information on the typical submission process here. A quick search did show that Ivy Wallet uses Firebase for crash analytics - you will have to run a different flavor for F-droid without Firebase, as it is not allowed on the main repository - ACRA is used as an open-source alternative, with other alternatives available here (must be set as opt-in).

As far as the other parts, I can't really speak to them as I am not a developer, but generally closed-source parts/blobs would need to be removed and/or replaced.

Edit: For push notifications, see UnifiedPush.

PoorPocketsMcNewHold commented 2 years ago

I would add, that such motifications, could be made for a different "Free" branch to this one, if you do want to keep the proprietary non-free bits of your application on lther Store platforms.

Poussinou commented 2 years ago

Hi,

Since we are stuck on F-Droid inclusion due to non-free components, could you please in the meantime attach a signed release APK for every release you tag, so that people without Play Store can download and update your app easily? Thanks

ILIYANGERMANOV commented 2 years ago

Hi @Poussinou I'll add this step in the release CI, can you the internal_release task, it might already contain it.

ILIYANGERMANOV commented 1 year ago

Can anyone implement that? It's pretty important one.

Success Criteria

This should be automated and included as another job in the internal_release.yml. After a successful internal release we should publish to F-Droid.

ILIYANGERMANOV commented 12 months ago

Hey, this one is open? If someone can pick it up, it would be highly appreciated

YatinGarg07 commented 8 months ago

Hi @ILIYANGERMANOV, i want to work on this. for clarity - I have to generate a signed release apk for every release ? in internal_release.yml is that all?

ILIYANGERMANOV commented 8 months ago

Hey @YatinGarg07 there's no deadline, as long as it takes. However, if more than 4-5 days have passed and another contributor wants it and can deliver it sooner - it'll get reassigned to them. I'd be really excited if we can do the F-Droid release 🚀 If you want to work on it, read our CONTRIBUTING.MD and follow the process