Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for android that you can either build or download from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.53k stars 588 forks source link

Migrate `:screen-loans` to ComposeViewModel and our new architecture #2624

Closed ILIYANGERMANOV closed 9 months ago

ILIYANGERMANOV commented 10 months ago

Please confirm the following

What would you like to improve?

Because...

Description

Migrate the screen by extending ComposeViewModel and following the pattern described here: https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/Architecture.md

Success Criteria

vartult commented 10 months ago

Hey @ILIYANGERMANOV assign this to me!

ILIYANGERMANOV commented 10 months ago

Done ✅ Make sure to check how we migrated our other screens to ComposeViewModel

vartult commented 10 months ago

Hey @ILIYANGERMANOV , LoanModalData is deprecated, are we supposed to create a new modal for the loan data or if you help with navigating to the new one.

ILIYANGERMANOV commented 10 months ago

Hey @ILIYANGERMANOV , LoanModalData is deprecated, are we supposed to create a new modal for the loan data or if you help with navigating to the new one.

Good question @vartult just use the deprecated one. The scope of the task is only to migrate the ViewModel to ComposeViewModel which will be a great leap forward. In the future, in follow-up tasks we'll get rid of the deprecated Ivy components and replace them with Material3 ones