[FEATURE] Add "GitHub" button in the Settings screen

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.81k stars 677 forks source link

[FEATURE] Add "GitHub" button in the Settings screen #2675

Closed ILIYANGERMANOV closed 1 year ago

ILIYANGERMANOV commented 1 year ago

Please confirm the following

[X] I checked the current issues for duplicate issues

What do you want to be added or improved?

As a user, I want to have a "GitHub" button in Ivy Wallet's Settings screen that open the Ivy Wallet GitHub repo.

Why do you need it?

I want to see the project's open-source repo.
The more people that see the repo, the more contributors we'll get.

How do you imagine it?

I colorful "GitHub' button in the Settings screen right below "Share Ivy Wallet" in the "Other" section. When click the button should open:

https://github.com/Ivy-Apps/ivy-wallet

SamantaTarun commented 1 year ago

May I get this issue assigned to me?

ILIYANGERMANOV commented 1 year ago

Thank you for your interest! Done ✅

TharunBalaji2004 commented 1 year ago

Hi there, I'm pretty much impressed towards the UI/UX environment of the entire app and I wish to work on this feature. If possible, can I get assigned to this?

ILIYANGERMANOV commented 1 year ago

Hi there, I'm pretty much impressed towards the UI/UX environment of the entire app and I wish to work on this feature. If possible, can I get assigned to Il

Hi there, I'm pretty much impressed towards the UI/UX environment of the entire app and I wish to work on this feature. If possible, can I get assigned to this?

Ups, my bad! Sorry, stupid me misclicked and assigned the wrong person 😬 It's yours, my friend.

ILIYANGERMANOV commented 1 year ago

Ohh shit it's taken, I should stop watching between the lines. It was originally assigned to @tarunsamanta2k20. @TharunBalaji2004 let's wait and see if @tarunsamanta2k20 is still on it?

TharunBalaji2004 commented 1 year ago

Yeah its okay alright, multiple persons could not work on same issue?

ILIYANGERMANOV commented 1 year ago

Currently, nope because at the end of the day - I'll be able to merge only one PR and someone who worked will have to discard their efforts and that's not fair https://github.com/Ivy-Apps/ivy-wallet/blob/main/CONTRIBUTING.md

ILIYANGERMANOV commented 1 year ago

@TharunBalaji2004 do you still want to take this one? I see that @tarunsamanta2k20 removed his assessment.

TharunBalaji2004 commented 1 year ago

Yeah sure, I'm interested to work on this also. Can you assign it to me

ILIYANGERMANOV commented 1 year ago

Thank you! Assigned to you

TharunBalaji2004 commented 1 year ago

GitHub Button Feature

@ILIYANGERMANOV I have added new GitHub button in "Others" section, it supports both Light and Dark mode and redirects to GitHub repo page 👍

ILIYANGERMANOV commented 1 year ago

@ILIYANGERMANOV I have added new GitHub button in "Others" section, it supports both Light and Dark mode and redirects to GitHub repo page 👍

Goood!! Raise it as PR

TharunBalaji2004 commented 1 year ago

Yeah I have given a PR request, kindly review it 👍